Step 1 is ready when the page opens, and shorter changelog entries - #138
Merged
Merged
Conversation
The What's new panel is a narrow column people skim. Today's six entries ran to four, five and six sentences each and rendered as a wall of text in it — the reasoning belongs in the commit message and the issue, not there. Shortened all six of today's entries and wrote the rule into AGENTS.md so it holds for the next one. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
is-locked dims a panel to 46% and kills pointer events on its buttons. That is right for a step you cannot reach yet, and wrong for the one you start in: syncControlStates() applied it to Step 1 whenever there were no prefixes, which is the state every fresh page opens in. So Step 1 rendered greyed out as if waiting on something, and the Spam incident tab (#133) could not be clicked at all — a button inside a locked panel, taking clicks as text selection, unreachable in exactly the case it exists for: no prefixes yet, load an incident to get some. The disabled Find Best Matching Region button already says prefixes are needed. Steps 2 and 3 keep locking, which is what the state was built for. Closes #137 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things from today's feedback on the column redesign.
Step 1 was locked until you typed (#137)
syncControlStates()putis-lockedon Step 1 whenever there were no first-hop prefixes — the state every fresh page opens in.is-lockeddims a panel toopacity: .46and setspointer-events: noneon its buttons, which is right for a step you cannot reach yet and wrong for the one you start in.It also made the Spam incident tab from #133 unclickable: a button inside a locked panel takes clicks as text selection. Unreachable in exactly the case it exists for — you have no prefixes and want to load an incident to get some.
Step 1 is never locked now. The disabled Find Best Matching Region button already carries "you need prefixes first". Steps 2 and 3 keep locking, which is what the state was built for.
Verified on a fresh page with no input: panel at full opacity,
pointer-events: autoon the tab, clicking it opens the incident pane.Changelog entries were a wall of text
Today's six entries ran to four, five and six sentences each and rendered as a block of prose in the narrow What's new column. Shortened all six to one or two sentences, and wrote the cap into
AGENTS.md§7 so the next one holds to it — the reasoning belongs in the commit message and the issue, not in that panel.🤖 Generated with Claude Code