Add eviction handler#8
Open
luzlab wants to merge 4 commits into
Open
Conversation
|
@DylanPiercey |
Author
|
@DylanPiercey @milkcha I'm not certain about is whether we should call the handler before or after the item is evicted. Any thoughts? |
Owner
|
@luzlab the main concern I have with this is that we are creating an event listener instance for a single event. It seems a bit wasteful to me. If it suites your use-case I think it'd be better just to have something like: const cache = new Receptacle();
cache.onDelete = (key, value) => {
console.log("deleted", key, "which was", value);
}Or just having it as an option to receptacle, eg: new Receptacle({
onDelete(k, v){ /* ... */ }
})Thoughts? |
|
i would like new Receptacle({
onDelete(k, v){ /* ... */ }
})it keep the lib simple and excellent quick. no need an event system. if we need , we can dispatch then event to other event lib use onDelete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a method
onto specify a callback that gets called when a key is expired.