Repository navigation
Fix red CI (Node 22) and refresh stale doc numbers - #31
Merged
Merged
Conversation
The smoke test's Play Together check uses the global WebSocket, which Node 20 doesn't have, so CI has been failing on main since the accounts merge (#30). Run CI on Node 22 like the server image. Also: quest count in README and ROADMAP (60), and an outdated 'no accounts' comment in the relay. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012T3WxfAesenfyvWRXYdNKy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
WebSocket, which Node 20 doesn't have, so CI has failed onmainsince the accounts merge (Accounts for the online edition; Play Together needs a login #30): "smoke test crashed (WebSocket is not defined)".server/rooms.mjscorrected.Verified
Ran
node tests/smoke.mjslocally on Node 22: all 29 checks pass, including accounts, Play Together and offline start.Generated by Claude Code