Repository navigation
Privacy: stop the code editor fetching icons from Google's servers - #32
Merged
Merged
Conversation
Blockly's default media path is blockly-demo.appspot.com, so opening Bit's code editor sent every player's IP address and browser details to Google (and showed broken trash/zoom icons offline). Bundle sprites.png (blockly@10.4.3), point the editor at it with the media option, and precache it (sw.js v20). The smoke test now fails if the game ever requests a host outside the one serving it, so this can't come back unnoticed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012T3WxfAesenfyvWRXYdNKy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Found in the pre-beta privacy audit. Opening Bit's code editor made the browser request
https://blockly-demo.appspot.com/static/media/sprites.png, because Blockly's default media path points at Google's demo server. Every player who opened the editor sent their IP address and browser details to Google. It also contradicted the README's "no external requests" claim and would show broken trash/zoom icons offline.What
vendor/media/sprites.png(fromblockly@10.4.3, 2.6 KB) and set Blockly'smediaoption to it (src/robotui.js).sw.js(bumped to v20) so the editor works offline.Verified
blockly-demo.appspot.com). After: all requests are same-origin andsprites.pngloads from/vendor/media/.node tests/smoke.mjson Node 22: all checks pass, including the new privacy check and offline start.Needs a redeploy (
tools/deploy-site.sh) to reach portal.dynamicweblab.com; GitHub Pages updates on merge.Generated by Claude Code