Repository navigation
Phones: crafting panel fits upright iPhones, and its close button shows - #34
Merged
Merged
Conversation
Reported on a real iPhone: the survival Inventory / Crafting panel ran off the right edge (text, the station note and every recipe cut off) with no way to close it. - The 9-slot rows were fixed at 482px, wider than an upright phone (375-390px), so the panel scrolled sideways inside itself. The slots now shrink to fit, recipes wrap, and the panel scrolls once; Done is pinned on upright phones - The close button gets its own layer above the panel: Safari can paint a panel that scrolls both ways on top of it - Pop-ups keep clear of the iPhone clock and home bar (safe-area padding), which matters for the home-screen app - The menu shows the game version (from the offline cache) so testers can tell which build a device is running; sw.js v22 - Smoke test: the crafting panel fits an upright phone Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012T3WxfAesenfyvWRXYdNKy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Reported from a real iPhone: the survival Inventory / Crafting panel ran off the right edge (subtitle, "No Furnace nearby" and every recipe card cut off) and there was no visible way to close it.
What
position: relative; z-index: 1), and the ✕ is promoted withtranslateZ(0). Safari can paint a panel that scrolls in both directions on top of a sibling button. Chromium emulation drew the ✕ fine, so this is the likely cause on the device but I couldn't reproduce it in WebKit.sw.jsv22.Verified
node tests/smoke.mjson Node 22: all checks pass.Needs a check on the real iPhone after deploying: the ✕ should appear in the top-right corner of the crafting panel.
Generated by Claude Code