Skip to content

Phones: crafting panel fits upright iPhones, and its close button shows - #34

Merged
maidulcu merged 1 commit into
mainfrom
claude/great-davinci-5u45cq
Nov 10, 2026
Merged

maidulcu merged 1 commit into
mainfrom
claude/great-davinci-5u45cq

Conversation

@maidulcu

Copy link
Copy Markdown
Contributor

Why

Reported from a real iPhone: the survival Inventory / Crafting panel ran off the right edge (subtitle, "No Furnace nearby" and every recipe card cut off) and there was no visible way to close it.

What

  • Overflow: the 9-slot rows were fixed at 482px, wider than an upright phone (375–390px), so the panel scrolled sideways inside itself. Slots now shrink to fit, recipes wrap, and the panel scrolls once (no recipe list scrolling inside it). Done is pinned to the bottom on upright phones. This was the only panel that overflowed; I measured all of them at 375, 390 and 667px wide.
  • Close button: the panel gets its own layer under the ✕ (position: relative; z-index: 1), and the ✕ is promoted with translateZ(0). Safari can paint a panel that scrolls in both directions on top of a sibling button. Chromium emulation drew the ✕ fine, so this is the likely cause on the device but I couldn't reproduce it in WebKit.
  • iPhone safe areas: pop-ups are padded clear of the clock and home bar. This matters in the home-screen app, where the panel ran under the status bar.
  • Version label: the menu shows "Version 22" (read from the offline cache) so testers can tell which build a device is running.
  • sw.js v22.

Verified

  • New smoke check: the crafting panel fits an upright phone (it was 176px too wide at 390px and 191px at 375px).
  • node tests/smoke.mjs on Node 22: all checks pass.
  • Screenshots of the crafting panel upright (390×844) and sideways (667×375) before and after.

Needs a check on the real iPhone after deploying: the ✕ should appear in the top-right corner of the crafting panel.


Generated by Claude Code

Reported on a real iPhone: the survival Inventory / Crafting panel ran off the
right edge (text, the station note and every recipe cut off) with no way to close it.
- The 9-slot rows were fixed at 482px, wider than an upright phone (375-390px),
  so the panel scrolled sideways inside itself. The slots now shrink to fit,
  recipes wrap, and the panel scrolls once; Done is pinned on upright phones
- The close button gets its own layer above the panel: Safari can paint a
  panel that scrolls both ways on top of it
- Pop-ups keep clear of the iPhone clock and home bar (safe-area padding),
  which matters for the home-screen app
- The menu shows the game version (from the offline cache) so testers can
  tell which build a device is running; sw.js v22
- Smoke test: the crafting panel fits an upright phone

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012T3WxfAesenfyvWRXYdNKy
@maidulcu
maidulcu marked this pull request as ready for review November 10, 2026 07:23
@maidulcu
maidulcu merged commit 22d16d8 into main Nov 10, 2026
1 check failed
@maidulcu
maidulcu deleted the claude/great-davinci-5u45cq branch November 10, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants