Skip to content

Fix red CI: recipe badges no longer push crafting cards wider; steadier phone checks - #35

Merged
maidulcu merged 2 commits into
mainfrom
claude/great-davinci-5u45cq
Nov 10, 2026
Merged

maidulcu merged 2 commits into
mainfrom
claude/great-davinci-5u45cq

Conversation

@maidulcu

@maidulcu maidulcu commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Why

CI has been red on main since #33: the two new phone smoke checks failed on GitHub's runner while passing locally. A live test of the Pages site (Version 22) also found the crafting panel 10px too wide on a 360px Android phone.

What

  • Crafting cards overflow on narrow phones. CI's runner falls back to a wider font (DejaVu Sans). Reproducing with that font found the real cause: each recipe's "Craft anywhere" / "Needs Crafting Table" badge never wraps and sat beside the name. That overflowed even with the normal font at 360px (a common Android width) and at 320px. On narrow screens the badge now goes under the ingredients. Nothing overflows at 320, 360 or 375px with either font. The check now runs at 360px.
  • "Upright pauses" timing. The check waited a fixed 300ms after rotating, too short for CI's slow software rendering. It now waits for the change itself (up to 15s).
  • sw.js v23, so phones pick up the fix and the menu shows a new version.

Verified

  • Measured the crafting panel at 320/360/375px with Inter and DejaVu Sans: 0px sideways overflow everywhere (was 3–58px).
  • node tests/smoke.mjs on Node 22: all checks pass. CI passed on the first commit; the second commit only bumps sw.js.

🤖 Generated with Claude Code

https://claude.ai/code/session_012T3WxfAesenfyvWRXYdNKy

…hone checks

CI failed the two new phone checks:
- 'Crafting panel fits' was 3px too wide on CI, which has a wider fallback font.
  The cause: each recipe's 'Craft anywhere' / 'Needs Crafting Table' badge
  never wraps and sat beside the name, so cards overflowed at 360px (a common
  Android width) even with the normal font. On narrow screens the badge now
  goes under the ingredients; nothing overflows at 320, 360 or 375px with
  either font. The check now runs at 360px
- 'Upright pauses' waited a fixed 300ms after rotating, too short for CI's
  slow software rendering. It now waits for the change itself

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012T3WxfAesenfyvWRXYdNKy
… new version)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012T3WxfAesenfyvWRXYdNKy
@maidulcu
maidulcu marked this pull request as ready for review November 10, 2026 08:12
@maidulcu
maidulcu merged commit 1ea9363 into main Nov 10, 2026
1 check passed
@maidulcu
maidulcu deleted the claude/great-davinci-5u45cq branch November 10, 2026 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants