Repository navigation
Fix red CI: recipe badges no longer push crafting cards wider; steadier phone checks - #35
Merged
Merged
Conversation
…hone checks CI failed the two new phone checks: - 'Crafting panel fits' was 3px too wide on CI, which has a wider fallback font. The cause: each recipe's 'Craft anywhere' / 'Needs Crafting Table' badge never wraps and sat beside the name, so cards overflowed at 360px (a common Android width) even with the normal font. On narrow screens the badge now goes under the ingredients; nothing overflows at 320, 360 or 375px with either font. The check now runs at 360px - 'Upright pauses' waited a fixed 300ms after rotating, too short for CI's slow software rendering. It now waits for the change itself Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012T3WxfAesenfyvWRXYdNKy
… new version) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012T3WxfAesenfyvWRXYdNKy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CI has been red on
mainsince #33: the two new phone smoke checks failed on GitHub's runner while passing locally. A live test of the Pages site (Version 22) also found the crafting panel 10px too wide on a 360px Android phone.What
sw.jsv23, so phones pick up the fix and the menu shows a new version.Verified
node tests/smoke.mjson Node 22: all checks pass. CI passed on the first commit; the second commit only bumpssw.js.🤖 Generated with Claude Code
https://claude.ai/code/session_012T3WxfAesenfyvWRXYdNKy