send_shipped_email has been moved to ShipmentHandler

[ehoch]

Hey guys so it looks like in 2.4 the Spree::ShipmentMailer.shipped_email code has been moved to the handler:

https://github.com/spree/spree/blob/2-4-stable/core/app/models/spree/shipment_handler.rb#L30

We need to make sure we decorate here as well or the Spree::Config.send_shipped_email doesn't work.

[joshnuss]

Thanks for the fix @ehoch !

Can you remove the unneeded method Spree::Shipment#send_shipped_email too?

[ehoch]

So I'm not sure if that one isn't ALSO needed because they still have that code in core:

https://github.com/spree/spree/blob/2-4-stable/core/app/models/spree/shipment.rb#L415

I just know that the Handler one gets called in our store so we were double emailing...

[joshnuss]

Looks like its dead code (cause its a private function and not called anywhere in the Shipment class), so we can safely remove it from spree_shipstation

[ehoch]

You are correct. Go Spree.

[joshnuss]

:)

[jormon]

fixed in #22