Handle new settings field#6678
Draft
avorima wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Propagate the new field value of the Kubernetes connection setting to the DynaKube status.
The value is read in GetK8sClusterME and the DynaKube status field is updated in the k8sentity reconciler.
API change
status.tenant.useIngestEnrichmentConfigSchemaboolean field toDynaKube. Uses a pointer to differentiate between unset, e.g. due a transient error, and false.ICP-3071
How can this be tested?
The API isn't ready yet, but you can test that the boolean appears when deploying a DynaKube.