Skip to content

Fix FillValueTest failure in CTest#464

Merged
sbrus89 merged 2 commits into
E3SM-Project:developfrom
hyungyukang:omega/fix-fillvalue-test
Jul 9, 2026
Merged

Fix FillValueTest failure in CTest#464
sbrus89 merged 2 commits into
E3SM-Project:developfrom
hyungyukang:omega/fix-fillvalue-test

Conversation

@hyungyukang

Copy link
Copy Markdown

This PR fixes the FillValueTest failure in CTests that appeared after merging the fill value PR (#428) and the vertical mixing tendency PR (#410). The test now initializes VertMix and Eos as required.

Checklist

  • Linting
  • Building
    • CMake build does not produce any new warnings from changes in this PR
  • Testing
    • Add a comment to the PR titled Testing with the following:
      • Which machines CTest unit tests
        have been run on and indicate that are all passing.
      • Indicate "All tests passed" or document failing tests

@hyungyukang hyungyukang requested a review from katsmith133 July 8, 2026 21:43
@hyungyukang

Copy link
Copy Markdown
Author

Testing

CTest unit tests

  • Machine: Frontier
  • Compiler: craygnu, craygnu-mphipcc
  • Build type: Release
  • Result: All tests passed

@katsmith133

Copy link
Copy Markdown

Testing

CTest unit tests

  • Machine: PM-CPU, PM-GPU
  • Compiler: gnu, gnugpu
  • Build type: Release
  • Result: All tests passed

@katsmith133 katsmith133 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based upon visual inspection and testing done by @hyungyukang on Frontier and myself on PM.

@sbrus89

sbrus89 commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

All CTests pass on chrysalis (oneapi-ifx). Thanks to @alicebarthel for noticing and to hyungyukang and @brian-oneill for helping with the fix.

@sbrus89 sbrus89 merged commit 3026a5f into E3SM-Project:develop Jul 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants