Require state vars in write_initial_state_dataset, including surface pressure#615
Open
cbegeman wants to merge 16 commits into
Open
Require state vars in write_initial_state_dataset, including surface pressure#615cbegeman wants to merge 16 commits into
write_initial_state_dataset, including surface pressure#615cbegeman wants to merge 16 commits into
Conversation
cbegeman
changed the title
write_initial_state_dataset, including surface pressure
Collaborator
Author
Testingwith Polaris
|
cbegeman
force-pushed
the
incl-surf-pressure-in-state-vars
branch
3 times, most recently
from
9b18ad9 to
7cf5b3f
Compare
cbegeman
force-pushed
the
incl-surf-pressure-in-state-vars
branch
from
7cf5b3f to
00796e1
Compare
Collaborator
|
It's fine to just remove check-list items that don't apply. I personally prefer that to crossing them out. |
xylar
added
enhancement
xylar
reviewed
Jun 30, 2026
xylar
left a comment
xylar
left a comment
Collaborator
There was a problem hiding this comment.
I rebased this onto main and the tested with E3SM-Project/Omega#433, using Omega develop and Polaris main as the baseline.
Polaris omega_pr suite
- Baseline workdir:
/lcrc/group/e3sm/ac.xylar/polaris_1.0/chrysalis/test_20260630/omega-pr-develop - Baseline build:
/lcrc/group/e3sm/ac.xylar/polaris_1.0/chrysalis/test_20260630/omega-pr-develop/build - PR build:
/lcrc/group/e3sm/ac.xylar/polaris_1.0/chrysalis/test_20260630/omega-pr-surf-press-in-state-check/build - PR workdir:
/lcrc/group/e3sm/ac.xylar/polaris_1.0/chrysalis/test_20260630/omega-pr-surf-press-in-state-check - Machine:
chrysalis - Partition:
compute - Compiler:
oneapi-ifx - Build type:
Release - Log:
/lcrc/group/e3sm/ac.xylar/polaris_1.0/chrysalis/test_20260630/omega-pr-surf-press-in-state-check/polaris_omega_pr.o1243944 - Result: All tests passed
The code looks good.
I would like to take out 00796e1 if #632 makes it in before this PR.
I will approve as soon as we bring E3SM-Project/Omega#433 in via a submodule update.
Collaborator
Author
6 tasks
14 tasks
… vars on write_initial_state_dataset
…ertial_wave because it does not use tracers
…ables_yaml call because the first call with configure occurs before the model attribute is available
Collaborator
Author
TestingRe-tested after surface pressure was moved from the state to vert_coord: Polaris
|
cbegeman
force-pushed
the
incl-surf-pressure-in-state-vars
branch
from
00796e1 to
fa4394d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO to include submodule update to E3SM-Project/Omega#433
Currently,
write_vert_coord_datasetrequires thevert_coordvariables. Similarly, herewrite_initial_state_datasetrequires thestatevariables. This ensures that all model-specific required inputs are present.Thus, this PR adds
surfacePressureto the initial state dataset, requiring that Omega have the capability to read it in, provided by E3SM-Project/Omega#433.The implications of this PR are that any tests not using all of the state variables (e.g., those not including tracers) must use
write_model_datasetoradd_outputs_for_model_inputs(..., skip_validation=True), which does not require state variables by default.Checklist
Testingcomment in the PR documents testing used to verify the changesFixes #594