Add all horizontal advection orders with del4 to overflow#669
Merged
Conversation
cbegeman
approved these changes
Jul 20, 2026
cbegeman
left a comment
Collaborator
There was a problem hiding this comment.
This is perfect. Can you just confirm that all tests appear when you do polaris list -t ocean/planar/overflow? If that's the case, I'm fine merging this small fix without further testing.
Contributor
Author
TestingI was able to setup and run |
Contributor
Author
|
@cbegeman, they are all showing up for me with |
Collaborator
|
Thanks, @sbrus89 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
omega_prsuite contains thesmoke_test_horiz_adv_order_2_del4test, but the only del4 variant added by the overflow tasks issmoke_test_horiz_adv_order_4_del4. This PR adds a del4 variant for all orders.Fixes #668
Checklist
api.md) has any new or modified class, method and/or functions listedTestingcomment in the PR documents testing used to verify the changes