Skip to content

Add all horizontal advection orders with del4 to overflow#669

Merged
cbegeman merged 1 commit into
E3SM-Project:mainfrom
sbrus89:overlflow_del4
Jul 20, 2026
Merged

Add all horizontal advection orders with del4 to overflow#669
cbegeman merged 1 commit into
E3SM-Project:mainfrom
sbrus89:overlflow_del4

Conversation

@sbrus89

@sbrus89 sbrus89 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Currently, the omega_pr suite contains the smoke_test_horiz_adv_order_2_del4 test, but the only del4 variant added by the overflow tasks is smoke_test_horiz_adv_order_4_del4. This PR adds a del4 variant for all orders.

Fixes #668

Checklist

  • User's Guide has been updated
  • Developer's Guide has been updated
  • API documentation in the Developer's Guide (api.md) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • Testing comment in the PR documents testing used to verify the changes
  • New tests have been added to a test suite

@sbrus89
sbrus89 requested a review from cbegeman July 20, 2026 19:45

@cbegeman cbegeman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect. Can you just confirm that all tests appear when you do polaris list -t ocean/planar/overflow? If that's the case, I'm fine merging this small fix without further testing.

@sbrus89

sbrus89 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Testing

I was able to setup and run omega_pr with mpas-ocean on perlmutter cpu.

@sbrus89

sbrus89 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

@cbegeman, they are all showing up for me with polaris list:

 148: ocean/planar/overflow/smoke_test_horiz_adv_order_2
 149: ocean/planar/overflow/smoke_test_horiz_adv_order_2_del4
 150: ocean/planar/overflow/smoke_test_horiz_adv_order_3
 151: ocean/planar/overflow/smoke_test_horiz_adv_order_3_del4
 152: ocean/planar/overflow/smoke_test_horiz_adv_order_4
 153: ocean/planar/overflow/smoke_test_horiz_adv_order_4_del4
 154: ocean/planar/overflow/rpe

@cbegeman

Copy link
Copy Markdown
Collaborator

Thanks, @sbrus89 !

@cbegeman
cbegeman merged commit 1b0aaf1 into E3SM-Project:main Jul 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in setting up omega_pr suite due to missing smoke_test_horiz_adv_order_2_del4 test

2 participants