Fix #372: Remove redundant manual CORS headers in app.py#373
Open
SriHarsha-23 wants to merge 1 commit intoEAPD-DRB:mainfrom
Open
Fix #372: Remove redundant manual CORS headers in app.py#373SriHarsha-23 wants to merge 1 commit intoEAPD-DRB:mainfrom
SriHarsha-23 wants to merge 1 commit intoEAPD-DRB:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Existing related work reviewed
Overlap assessment
Why this PR should proceed
Summary
@app.after_requestblock inAPI/app.pythat manually injected CORS headers.Flask-CORSmiddleware (CORS(app)). The manual hook was injecting duplicateAccess-Control-Allow-Originheaders (violating W3C specs) and hardcoding an invalid portless localhost origin along with dead Heroku routes. Removing it allowsFlask-CORSto handle cross-origin requests securely and dynamically.Validation
Validation steps: Verified that
API/app.pycompiles and the local Flask server runs successfully without the removed block, allowingFlask-CORSto handle headers normally.Documentation
Scope check
OSeMOSYS/MUIOdependencyEAPD-DRB/MUIOGO:main(not upstream)Exception rationale