Improve wrapping logic and simplify triclinic → orthorhombic handling#379
Open
ayushk687 wants to merge 1 commit intoEAPD-DRB:mainfrom
Open
Improve wrapping logic and simplify triclinic → orthorhombic handling#379ayushk687 wants to merge 1 commit intoEAPD-DRB:mainfrom
ayushk687 wants to merge 1 commit intoEAPD-DRB:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR simplifies and standardizes the wrapping workflow by introducing a cleaner abstraction for handling triclinic and orthorhombic box representations.
closes #348
It removes redundant wrapping logic and ensures consistent behavior across different box types.
Problem
Currently, wrapping logic requires:
Manual detection of triclinic boxes
Multiple wrap() calls
Explicit conversion to orthorhombic boxes
Example:
def wrap_atoms(universe, compound=None):
ts = universe.trajectory.ts
dims = ts.dimensions