Validate model version during model load#381
Open
mengChengxi wants to merge 1 commit intoEAPD-DRB:mainfrom
Open
Validate model version during model load#381mengChengxi wants to merge 1 commit intoEAPD-DRB:mainfrom
mengChengxi wants to merge 1 commit intoEAPD-DRB:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Existing related work reviewed
Overlap assessment
Why this PR should proceed
Summary
API/Classes/Base/ModelVersionClass.pyversion_mismatcherrors for missing or incompatible schema versionsCustomExceptionJSON error handler inAPI/app.pyOsemosysClassmodelVersionalongsideosy-versionwhen saving new/current models and importing templatesmodelVersionfor uploaded5.0archives without changing the legacy upload/update flowmodelVersion || osy-versionValidation
Validation performed:
python3 -m py_compileon all changed Python filesviewDatareturns409withversion_mismatch5.0archive missingmodelVersionis backfilled on restoreDocumentation
Scope check
OSeMOSYS/MUIOdependencyEAPD-DRB/MUIOGO:main(not upstream)Exception rationale