fix: adopt v5.5 result metadata and register missing result groups (#392)#405
Open
parthdagia05 wants to merge 1 commit intoEAPD-DRB:mainfrom
Open
fix: adopt v5.5 result metadata and register missing result groups (#392)#405parthdagia05 wants to merge 1 commit intoEAPD-DRB:mainfrom
parthdagia05 wants to merge 1 commit intoEAPD-DRB:mainfrom
Conversation
…PD-DRB#392) Align result metadata with upstream MUIO v5.5 as the authoritative source. Variables.json fixes: - OV, NONTU, UDCI_d, UDCE_d: fill empty unit rules with correct values - TEP: CapUnitId → milion Currency (cost variable, not capacity) - AEL_d: EmiUnit → milion Currency / EmiUnit (shadow price composite unit) - EB_d: CapUnitId → milion Currency / EmiUnit, rename to "Energy Balance" - ROA: add /years divisor for rate unit - ROPBT, ROUBT: add /years divisor for rate units Const.Class.js: - Add R, RYC, RYCn to RESULTGROUPNAMES, RESULTPARAMORDER, and RESULTPARAMCOLORS so the pivot UI can navigate to Objective Value, commodity shadow prices, and constraint shadow prices.
Author
|
@SeaCelo this PR is ready for a review. |
This was referenced Apr 2, 2026
Open
This was referenced Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align result metadata with upstream MUIO v5.5
Align result metadata with upstream MUIO v5.5 as the authoritative source.
Variables.json fixes
OV, NONTU, UDCI_d, UDCE_d
unitRulevalues with correct definitionsTEP
CapUnitId→milion CurrencyAEL_d
EmiUnit→milion Currency / EmiUnitEB_d
CapUnitId→milion Currency / EmiUnitROA
/yearsdivisor to represent rateROPBT, ROUBT
/yearsdivisor to represent rate unitsConst.Class.js updates
Added missing result groups so they are accessible in Pivot UI:
Added to:
RESULTGROUPNAMESRESULTPARAMORDERRESULTPARAMCOLORSNew groups:
R→ Objective ValueRYC→ Commodity shadow pricesRYCn→ Constraint shadow pricesLinked issue
Existing related work reviewed
Reviewed PRs/issues:
None modify:
Variables.jsonunit rulesConst.Class.jsresult group registrationOverlap assessment
Reason:
No existing PR addresses:
Variables.jsonR,RYC,RYCnregistrationsWhy this PR should proceed
Shadow prices (
AEL_d,EB_d,UDCI_d,UDCE_d)TEPRate variables (
ROA,ROPBT,ROUBT)/years, leading to incorrect interpretationResult groups (
R,RYC,RYCn)Summary
What changed:
Variables.jsonConst.Class.jsWhy:
Validation
Validation steps
TEPandNONTUshow correct units underRYTRYC,RYE,RYCngroups via selectorR) shows unit =numberROA,ROPBT,ROUBTinclude/yearsin unitsDocumentation
Scope check
OSeMOSYS/MUIOEAPD-DRB/MUIOGO:mainException rationale