fix: correct first element condition in ImportTemplate loops (fixes #358)#409
Open
Cypher-CP0 wants to merge 1 commit intoEAPD-DRB:mainfrom
Open
fix: correct first element condition in ImportTemplate loops (fixes #358)#409Cypher-CP0 wants to merge 1 commit intoEAPD-DRB:mainfrom
Cypher-CP0 wants to merge 1 commit intoEAPD-DRB:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Existing related work reviewed
Overlap assessment
Why this PR should proceed
instead of stable base IDs, breaking deterministic model initialization
and any downstream logic depending on TEC_0, COM_0, EMI_0, STG_0
Summary
enumerate()to the four affected loops(technologies, commodities, emissions, storages) in
ImportTemplate.pyand replaced
obj == 0withi == 0in each. Also fixed an incorrectdefault description string "Default commodity" inside the technologies
loop (line 633).
objis a dictionary, not an integer, soobj == 0alwaysevaluates to
False. This meantfirst=Truewas never passed,so stable base IDs (TEC_0, COM_0, EMI_0, STG_0) were never assigned
to the first element of each entity type during template import.
Validation
Documentation
Scope check
OSeMOSYS/MUIOdependencyEAPD-DRB/MUIOGO:main(not upstream)Exception rationale