fix:#386 replace hardcoded HEROKU URL with configurable API_BASE_URL#410
Open
Cypher-CP0 wants to merge 1 commit intoEAPD-DRB:mainfrom
Open
fix:#386 replace hardcoded HEROKU URL with configurable API_BASE_URL#410Cypher-CP0 wants to merge 1 commit intoEAPD-DRB:mainfrom
Cypher-CP0 wants to merge 1 commit intoEAPD-DRB:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Existing related work reviewed
Overlap assessment
Why this PR should proceed
https://osemosys.herokuapp.com/URL silently breaks all API calls on any non-Heroku deployment. The fix is a single-file, non-breaking change that unblocks cloud and multi-user deployments with zero impact on local dev workflows.Summary
static HEROKU = 0flag and the hardcodedhttps://osemosys.herokuapp.com/URL fromWebAPP/Classes/Base.Class.js.apiUrl()now reads fromwindow.API_BASE_URLif set at deploy time, falling back towindow.location.originfor local and standard same-origin deployments.HEROKU = 1hardcoded the API target to a specific Heroku app, causing all API calls to silently fail on any other deployment environment. Replacing it withwindow.API_BASE_URLmakes the URL configurable without touching source code, following 12-factor app principles.Validation
Documentation
Scope check
OSeMOSYS/MUIOdependencyEAPD-DRB/MUIOGO:main(not upstream)Exception rationale