Skip to content

Conversation

@griffinhadfield
Copy link

Testing plan:

GIFs or screenshots:

@griffinhadfield griffinhadfield changed the title Quote edit message [WIP] Quote edit message Dec 6, 2021
@YuhuiJiang99
Copy link
Collaborator

YuhuiJiang99 commented Dec 6, 2021

I already pulled the changes to my local side and tested the codes manually. Everything works as expected. Good job @griffinhadfield!

Copy link

@LaithHanania LaithHanania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! The failing tests are fairly simple to fix, remove some whitespace and newline characters and all the checks should be successful.

@YuhuiJiang99 YuhuiJiang99 force-pushed the quote-edit-message branch 9 times, most recently from 31d789b to fde5912 Compare December 12, 2021 00:00
@griffinhadfield griffinhadfield changed the base branch from develop to main December 13, 2021 20:12
@JoshuaPius
Copy link

Is there anyway we can make the checks that are not passing pass??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants