Fix Oura login and Electron activation crash - #10
Open
seddm-sketch wants to merge 1 commit into
Open
seddm-sketch wants to merge 1 commit into
seddm-sketch wants to merge 1 commit into
Conversation
seddm-sketch
marked this pull request as ready for review
June 11, 2026 16:24
seddm-sketch
marked this pull request as draft
June 11, 2026 16:29
seddm-sketch
marked this pull request as ready for review
June 11, 2026 16:30
manojatchut
approved these changes
Jul 5, 2026
manojatchut
approved these changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two runtime issues found while using the packaged macOS app:
mainWindow.show()was called beforemainWindowhad been initialized.Root Cause
Oura’s auth screen now renders multiple
button[name="selectedId"]buttons. The login automation used that broad locator directly, which caused Playwright strict mode to fail because it matched both the passkey and email-code buttons.Electron also declared
mainWindowwithout an initial value. On macOS, theactivateevent can fire whilemainWindowis stillundefined, causing an uncaught exception when calling.show().Changes
.firstfor OTP input locators to avoid strict-mode ambiguity.mainWindowtonull.showOrCreateWindow()helper for macOS activation and tray open actions.Verification