Live-retrieval: fix file upload crash caused by output path conflict between dispatcher and post-processor#269
Open
AZOGOAT wants to merge 1 commit into
Open
Conversation
…er and post-processor
Collaborator
|
still needed? @AZOGOAT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where uploading a file via the live-retrieval API (
/v1/files,/v1/files/bulk,/v1/files/{fileId}) crashes withIsADirectoryError.Bug
When uploading a file via the
/v1/filesAPI, theprocess_files_defaultfunction uses the same path (./tmp/my_docs) for two different purposes:Since the folder already exists when the post-processor runs, it crashes with
IsADirectoryError: [Errno 21] Is a directory: './tmp/my_docs'. The file gets saved to./uploads/but is never indexed, so retrieval returns nothing.Error logs
Fix
Append
/results.jsonlto the post-processor output path so it writes a file inside the existing directory instead of trying to overwrite it.