Resolve issues: #24, #64, #82, #118, other fixes#148
Conversation
…ertical_dimension. The description contains additional clarifying wording if needed
…ll as consistency with CF standard Names.
climbfuji
left a comment
There was a problem hiding this comment.
I know this is just a draft, but I am happy with the changes.
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| uses: actions/checkout@v6 |
There was a problem hiding this comment.
Look how up to date we are!
|
Thanks @climbfuji, I had forgotten a couple things in my original PR so I marked it as a draft while resolving those...the only differences between the original and the latest (ready for review) version is removing Mike W from the codeowners and changing all mentions of "sea level" to "mean sea level" (#82). |
|
@climbfuji Could you give this an official approval? @nusbaume @svahl991 I'd appreciate a review when you get a chance, thanks! |
nusbaume
left a comment
There was a problem hiding this comment.
Thanks for the ping @mkavulich! I have two optional requests, but otherwise this PR looks good to me.
| if not os.access(schema_file, os.R_OK): | ||
| emsg = "validate_xml_file: Cannot open schema, '{}'" | ||
| raise ValueError(emsg.format(schema_file)) | ||
| raise FileNotFoundError(f"validate_xml_file: Cannot find schema file {schema_file}") |
There was a problem hiding this comment.
I might put quotes around {schema_file} here in case a blank string was ever passed in by mistake:
| raise FileNotFoundError(f"validate_xml_file: Cannot find schema file {schema_file}") | |
| raise FileNotFoundError(f"validate_xml_file: Cannot find schema file '{schema_file}' ") |
| # These owners will be the default owners for everything in the repo. | ||
|
|
||
| * @cacraigucar @climbfuji @dustinswales @grantfirl @mattldawson @mkavulich @mwaxmonsky @nusbaume @peverwhee @MarekWlasak @svahl991 @ss421 | ||
| * @cacraigucar @climbfuji @dustinswales @grantfirl @mattldawson @mkavulich @nusbaume @peverwhee @MarekWlasak @svahl991 @ss421 |
There was a problem hiding this comment.
I would remove @mattldawson as well, as I don't believe he is with NCAR anymore. I can look for an alternative NCAR chemistry representative in case we need one for future chemistry-related name changes/additions (which I can always add to the CODEOWNERS file in a later PR).
Description
Resolving several open issues and items noted on previous PRs:
air_pressure_at_sea_levelorair_pressure_at_mean_sea_levelor both? #82tools/lib/xml_tools.pyIssues
Resolves #24, #64, #82, #118