Do NOT auto-pass first job#5004
Merged
Merged
Conversation
f4a5c7e to
9573a76
Compare
rljacob
approved these changes
Jun 25, 2026
Contributor
Author
|
@billsacks , can you take a quick look at this? It could potentially impact CESM. |
Member
|
@jgfouca - Do you have a sense of what, specifically, we should look for in our workflow xml file to make sure this won't break anything for us? @mnlevy1981 and @fischer-ncar - also looping you two in, in the hopes that you might be more familiar with this workflow stuff than I am. |
Contributor
Author
|
@billsacks , the CESM file looks OK to me. I don't see a workflow that won't run when it should. |
Member
|
Thanks for looking & confirming, @jgfouca ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Even though this is a small code change, this is a significant change to how CIME works. For reasons I don't understand, we had the first job in the workflow list skip the prereq check. I had no idea why we did this since it's easy to not provide a prereq if you don't want one. This design lead to surprises, like my case.build running at SUBMIT even though I had prereq set to False (since I never want to run it during SUBMIT).
This needs to be merged quickly so I can update E3SM's cime because a lot of stuff is broken there.
CESM folks may want to double-check their workflow XML to make sure this won't break you.
Checklist