Fix CI #150
Closed
Fix CI #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typing-extensions 4.2.0 is not compatible with Python 3.6, and breaks `pytest`.
`5.10` (the latst version) seems to be incompatible with `jaraco.text`, which is an indirect dependency of `cherrypy`. Fix #151
| - pytest-xvfb | ||
| {% endif %} | ||
|
|
||
| - typing-extensions <4.2.0 # [PYTHON_VERSION=="3.6"] |
Contributor
There was a problem hiding this comment.
I think we always default PYTHON_VERSION to "3.6" given we never explicitly set it.
The variables were incorrectly defined, resulting in all builds being done in Python 3.6.
To test in all platforms we cannot pin to 5.12, as it is not available in later Pythons.
nicoddemus
force-pushed
the
fix-ci
branch
2 times, most recently
from
71652a7 to
6370f7a
Compare
This should not be needed anymore, installing from conda-forge is sufficient.
nicoddemus
force-pushed
the
fix-ci
branch
2 times, most recently
from
a4431af to
2ee9e50
Compare
When changing from phantomsj to firefox the messages started to be prefixed with "ERROR: ". I could also have changed `SeleniumExtras.get_exception_message` to drop the prefix, in retrospect that would have been easier because the expected values will not have to be changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typing-extensionsin Python 3.6: typing-extensions 4.2.0 is not compatible with Python 3.6.importlib_resources: 5.10 seems to be incompatible withjaraco.text(indirect dependency ofcherrypy).Fix #151
Close #149