UCAAS-1445: safe telemetry invoke context retention (7.0.10) - #142
Merged
JanFellner merged 3 commits intoJul 24, 2026
Conversation
…ntion Add final CloneForTelemetryRetention on SnaccInvokeContext, clear lib async borrows on the clone, and call PrepareForTelemetry for product hooks. Wire SnaccTelemetry to the new path and extend tests. Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CloneForTelemetryRetention()onSnaccInvokeContext: clones via productClone(), clears lib async borrows on the retained copy, then calls protectedPrepareForTelemetry()for product hooks.SnaccTelemetryDatafinalization through the new path instead of retaining a live dispatch context.PrepareForTelemetryin the sample harness.Consumer follow-up
ProCall UCServer should override
PrepareForTelemetry()onENetCtiCustomInvokeContext(see related GitLab branchfeature/UCAAS-1445-telemetry-invoke-context).Test plan
telemetry_tests(and full cpp-lib test target if available locally)