fix(favorites): confirm before overwriting dirty editor tab (closes #341) - #465
Merged
Conversation
) S-scope fix. handleClick in QueryFavorites previously overwrote a dirty query tab's content silently. Adds an isDirty guard that opens a ConfirmDialog ('Replace current tab content? Unsaved changes will be lost.') before replacing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
EVWorth
marked this pull request as ready for review
August 1, 2026 18:07
Resolves merge conflict with #337 (which was merged via #467). Combines both fixes: - Dirty-tab overwrite guard: handleClick (now via openFavorite helper) checks isDirty on the active query tab and opens a ConfirmDialog ('Replace current tab content? Unsaved changes will be lost.') before swapping the editor content for the favorite's SQL. - Delete-category confirm (from #337 via #467): separate ConfirmDialog with 'Delete category X? N favorites will be moved to Uncategorized.' The two ConfirmDialogs coexist (one driven by pendingFavorite + showConfirm, one by pendingDelete) and are visually distinct (one danger, one neutral). Tests: combined suite now exercises both flows with a single elaborate useContextMenu mock that renders context-menu items as buttons. Closes #341 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clicking a favorite while the editor has a dirty query tab silently replaces the tab's content with the favorite's SQL — losing unsaved edits.
handleClickcheckedactiveTab.type === 'query'but notisDirty. Adds an isDirty guard that opens a ConfirmDialog.Files
Test plan
Closes #341