fix(context-menu): auto-close on scroll/resize/visibilitychange (closes #455) - #472
Open
EVWorth wants to merge 1 commit into
Open
fix(context-menu): auto-close on scroll/resize/visibilitychange (closes #455)#472EVWorth wants to merge 1 commit into
EVWorth wants to merge 1 commit into
Conversation
#455) The context menu is anchored to absolute x,y from the right-click. Before this change, it survived scroll (orphaned, offscreen while grid scrolls beneath it), window resize (similar drift), and OS-driven visibility loss (menu stays open invisibly). Adds 3 listeners in the existing close-effect: - scroll (capture-phase, ancestor-aware) - resize (window) - visibilitychange (only when state -> hidden) 5 new tests cover each path plus a negative test that 'visible' visibility does NOT close. Closes #455 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The context menu was anchored to absolute x/y coordinates from the right-click. Before this change, it survived:
Adds 3 listeners in the existing close-effect:
scrollcapture-phase (ancestor-aware)resizeon windowvisibilitychangeonly when state transitions to hidden5 new tests cover each path + a negative test that 'visible' doesn't close.
Files
Test plan
Closes #455