Skip to content

Fix out-of-bounds access in EXI bitstream bounds check #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lippit wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix out-of-bounds access in EXI bitstream bounds check #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fecbb8
Fix out-of-bounds access in EXI bitstream bounds check
lippit Jun 24, 2026
1ec0c54
Fix undefined behavior in V2GTP header parsing
lippit Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/input/code_templates/c/static_code/exi_bitstream.c.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,11 @@ static int exi_bitstream_has_overflow(exi_bitstream_t* stream)
}
{%- endif %}
}
else
{
return EXI_ERROR__BITSTREAM_OVERFLOW;
}
}

if (stream->byte_pos >= stream->data_size)
{
return EXI_ERROR__BITSTREAM_OVERFLOW;
}

return EXI_ERROR__NO_ERROR;
Expand Down
5 changes: 3 additions & 2 deletions src/input/code_templates/c/static_code/exi_v2gtp.c.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,15 @@ int V2GTP20_ReadHeader(const uint8_t* stream_data, uint32_t* stream_payload_leng
}

/* check payload id */
payload_id = (stream_data[2] << 8) | stream_data[3];
payload_id = ((uint16_t)stream_data[2] << 8) | stream_data[3];
if (payload_id != v2gtp20_payload_id)
{
return V2GTP_ERROR__PAYLOAD_ID_DOES_NOT_MATCH;
}

/* determine payload length */
*stream_payload_length = (stream_data[4] << 24) | (stream_data[5] << 16) | (stream_data[6] << 8) | stream_data[7];
*stream_payload_length = ((uint32_t)stream_data[4] << 24) | ((uint32_t)stream_data[5] << 16) |
((uint32_t)stream_data[6] << 8) | stream_data[7];

return V2GTP_ERROR__NO_ERROR;
}
Expand Down