Skip to content

Remove the offline check from metering startup - #36

Merged
tescalada merged 2 commits into
mainfrom
remove-offline-metering-gate
Sep 24, 2026
Merged

tescalada merged 2 commits into
mainfrom
remove-offline-metering-gate

Conversation

@tescalada

Copy link
Copy Markdown
Contributor

Metering-provider startup no longer checks the offline setting. Offline mode keeps the ground from contacting the cloud and has nothing to do with metering, but ensure_metering_runtime and metering_lifespan both skipped startup when it was on, so a ground running offline never started its meter driver.

Both checks are removed, along with ConfigDict.is_offline() and the tests that asserted the skip. With no driver registered, startup still skips through the existing "metering provider is not configured" path.

Metering startup no longer checks OFFLINE: the checks in ensure_metering_runtime and metering_lifespan are removed, along with ConfigDict.is_offline() and the tests that set or asserted OFFLINE.
@github-actions

Copy link
Copy Markdown

Coverage

Coverage report
FileStmtsMissCoverMissing
sparkmeter
   __version__.py16288%32, 38
   _wsgi_mount_smoketest.py97970%19–152
   app.py3151197%19–20, 111, 368–375, 552–554, 675, 682–683
   asgi.py792766%45, 63–66, 86, 151–176, 183, 187
   cli.py40685%57–68
   cli_app.py880%4–20
   cli_prompts.py151220%8–12, 17–21, 26–28
   conftest.py2121095%92, 121–122, 155–156, 178–190, 279
   controller.py2434283%181, 205–206, 529, 583–640
   debug_memory.py32320%6–63
   periodic.py563145%60–66, 71–75, 80–84, 93–98, 103–111, 124–128
   sentry_proxy.py342235%38, 44–47, 56–65, 73–82
   servercommand.py1127236%47, 56–60, 64–69, 73–78, 82–85, 89–90, 101–103, 112–181
sparkmeter/alembic/versions
   0.32_merge_sms_tables.py46393%61–67
   0.77_snapshot_support.py128298%340, 401
sparkmeter/api
   customerviews0.py283199%301
   historyviews0.py1149219%49–55, 69–72, 81–131, 144–175, 185–216, 230–257
sparkmeter/config
   configparameter.py58297%80, 111
   configviews.py100397%157–159
   provider_settings.py673299%1269–1270
sparkmeter/database
   alchemy.py54493%61–63, 74
   database.py232399%497, 579–580
   ormobject.py55198%65
   session.py21210%12–62
   types.py54394%91–92, 125
sparkmeter/ground
   groundcommand.py201050%20–35
sparkmeter/history
   historyview.py351654%30–31, 41–54, 65–72
sparkmeter/meter
   meterdomain.py7732797%895, 1793–1794, 1805–1856, 1899
sparkmeter/metering
   api.py27967%66–76
   events.py164498%94, 294–295, 328
   reconcile.py123497%154–155, 268, 275
sparkmeter/system
   systemcommand.py67593%35, 130–132, 134–135
sparkmeter/tariff
   tariffcommand.py821582%27–44
sparkmeter/transaction
   transactionview.py167199%71
sparkmeter/user
   userdomain.py1871294%416–434
sparkmeter/web
   unittestutils.py1951194%73–81, 330, 339, 405, 407
   views.py72199%71
TOTAL1399362496% 

Tests Skipped Failures Errors Time
1676 0 💤 0 ❌ 0 🔥 2m 37s ⏱️

@github-actions

Copy link
Copy Markdown

Diff Coverage

Diff: origin/main...HEAD, staged and unstaged changes

No lines with coverage information in this diff.

@tescalada
tescalada merged commit 1ace176 into main Sep 24, 2026
13 of 17 checks passed
@tescalada
tescalada deleted the remove-offline-metering-gate branch September 25, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant