Repository navigation
Split the dev compose stack out to the workspace metarepo - #8
Merged
Merged
Conversation
The dev stack spans component repos: it builds the webapp from this repo, builds SymmetricDS from its own, and pulls the sparknet-http image. It cannot be assembled from this repo alone, so it moves to the groundbolt-dev workspace metarepo, which clones the components side by side. What stays here is the test harness, which CI must be able to run with only this repo checked out. It becomes docker-compose.test.yml -- a throwaway Postgres plus the test-image runner -- invoked with `docker compose -f docker-compose.test.yml`, replacing the `--profile test` selection the combined file needed. scripts/run_coverage.sh follows. The harness publishes the test database on an ephemeral host port instead of a fixed 5442, so a second checkout running its suite concurrently does not fail to bind. The test container reaches the database over the compose network, so no fixed port is needed.
Diff CoverageDiff: origin/main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dev compose stack spans component repos: it builds the webapp from this
repo, builds SymmetricDS from its own, and pulls the sparknet-http image.
That cannot be assembled from this repo alone, so it moves to the
groundbolt-dev workspace metarepo, which clones the components side by side.
What stays here is the test harness, which CI must be able to run with only
this repo checked out.
Changes
docker-compose.ymlremoved; the dev stack now lives in the workspace metarepo.docker-compose.test.ymladded: a throwaway Postgres plus the test-image runner.scripts/run_coverage.shand the README use-f docker-compose.test.ymlinplace of
--profile test.5442,so two checkouts can run their suites at the same time. The test container
reaches the database over the compose network.
Verification
docker compose -f docker-compose.test.yml configvalidates.