Skip to content

proper error handling when transient Pavlovia error occurs #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
khahani wants to merge 1 commit into
base: main
Choose a base branch
from
Open

proper error handling when transient Pavlovia error occurs #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions components/errorHandling.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,9 @@ const formatErrorContextAsHTML = (context) => {

const hasErrorContent = (error, message = "", stack = "") => {
return !!(
(error && typeof error === "object" && (error.message || error.stack)) ||
(error &&
typeof error === "object" &&
(error.message || error.stack || error.error)) ||
(message && message.trim()) ||
(stack && stack.trim()) ||
(error && typeof error === "string" && error.trim())
Expand Down Expand Up @@ -161,7 +163,7 @@ export const buildWindowErrorHandling = (paramReader) => {
showCursor();

const error = event.reason;
const message = error?.message || "";
const message = error?.message || error?.error || "";
const stack = error?.stack || "";

// Check if this is a meaningful error
Expand Down
Loading