Skip to content

migrate fpb-lint from travisci to gh actions#5186

Merged
eshellman merged 1 commit intoEbookFoundation:masterfrom
borgified:borgified/migrate_linter
Nov 29, 2020
Merged

migrate fpb-lint from travisci to gh actions#5186
eshellman merged 1 commit intoEbookFoundation:masterfrom
borgified:borgified/migrate_linter

Conversation

@borgified
Copy link
Copy Markdown
Contributor

What does this PR do?

migrate the fpb-lint automation running on travisci to github actions

@borgified borgified requested a review from eshellman November 24, 2020 23:47
@eshellman
Copy link
Copy Markdown
Collaborator

can we hold off on removing travis-ci until we have enough experience to see that

  • the new config does what we want
  • we can modify our documentation

@borgified
Copy link
Copy Markdown
Contributor Author

borgified commented Nov 25, 2020

was tested here: borgified#8
i did intentionally mess up the alphabetical ordering of a file and the linter found the error as expected but you dont see that output cuz i forced pushed to remove extraneous commits.

@eshellman
Copy link
Copy Markdown
Collaborator

travis-ci and gh-actions-lint run on both push and pull-request; shouldn't it be the same for gh actions?
I'd really like to be able to compare the two side-by-side - will that cause any problems?

@borgified
Copy link
Copy Markdown
Contributor Author

i think they both run on pull_request based on what ive seen on a few randomly selected PRs. (eg. https://github.com/EbookFoundation/free-programming-books/pull/5188/checks)

as configured, it will re-check if a change is made to the pull request.

@eshellman
Copy link
Copy Markdown
Collaborator

i'm just comparing the config files for the linter action and the link-check action and not that the "on" parameter is different. I've not so much as read the actions documentation, though.

@eshellman eshellman merged commit 37dc474 into EbookFoundation:master Nov 29, 2020
@eshellman
Copy link
Copy Markdown
Collaborator

merged, but restored the travis config so we can compare results and not confuse folks before documentation has changed

tt512 pushed a commit to tt512/free-programming-books that referenced this pull request May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants