fix(devices): correct iPhone Duo outer screen to its D-shaped corners - #24
Merged
Merged
Conversation
The outer screen used a uniform screenRadius, but the real device has near-right-angle corners on the hinge side and large rounded corners on the free edge. Adds a generic per-corner screenCorners override to DeviceShell (any corner can diverge from the uniform radius) and threads it through resolution, orientation rotation, and the rendered CSS so the D-shape rotates correctly between portrait and landscape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
screenCornersper-corner override toDeviceShell(backward compatible — omitted corners fall back to the uniformscreenRadius), threaded through resolution, portrait/landscape rotation, and the rendered CSS (--device-screen-radius-*variables and an elliptical.screen/body border-radius).screenRadius: 62scaled by screen width. Documented as provisional in a code comment.Test plan
pnpm --filter @devicekit/devices test— all passingpnpm --filter @devicekit/frame test— all passingpnpm --filter @devicekit/devices build/lint— cleanpnpm --filter @devicekit/frame build/lint— clean🤖 Generated with Claude Code