Skip to content

chore(lint): drop ESLint in favor of oxlint - #25

Merged
lbb00 merged 1 commit into
mainfrom
chore/drop-eslint-for-oxlint
Sep 14, 2026
Merged

lbb00 merged 1 commit into
mainfrom
chore/drop-eslint-for-oxlint

Conversation

@lbb00

@lbb00 lbb00 commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Both packages ran ESLint and oxlint side by side. Since oxlint already covers TypeScript/React lint here, this drops ESLint entirely: removes eslint.config.ts from packages/devices and packages/frame, drops the eslint/typescript-eslint/eslint-plugin-*/jiti/globals devDependencies, and moves the custom rules into .oxlintrc.jsonc (enabling the react plugin, no-empty with allowEmptyCatch, no-unused-vars underscore ignores, react/set-state-in-effect and react/incompatible-library off). lint is now just oxlint . at the root; per-package lint scripts are gone.

vite/vitest were already on v8 (vite@8.2.2, @vitest/coverage-v8), so no change needed there.

How was this verified?

  • pnpm lint — exit 0. One new warning from the newly-enabled react plugin at packages/frame/src/react/index.tsx:173 (writing to a ref during render, an intentional pattern with an existing comment explaining why); not addressed in this PR since it's a pre-existing pattern, not a regression.
  • pnpm check-types — exit 0.
  • pnpm test — exit 0, all suites pass (374 frame tests, devices tests, 13 script tests).

Checklist

  • Tests added or updated — n/a, tooling-only change, no new behavior to cover
  • pnpm lint passes with zero warnings — one pre-existing-pattern warning remains, see above
  • CHANGELOG.md updated under ## [Unreleased] — n/a, not user-facing

🤖 Generated with Claude Code

Both packages already ran oxlint alongside ESLint. Retire the
ESLint configs/deps entirely and move their custom rules
(no-empty allowEmptyCatch, no-unused-vars underscore ignores,
react/set-state-in-effect and react/incompatible-library off)
into .oxlintrc.jsonc, enabling the react plugin for packages/frame.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@lbb00
lbb00 merged commit 38eeb08 into main Sep 14, 2026
1 check passed
@lbb00 lbb00 mentioned this pull request Sep 14, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant