feat(frame): add crawlable device directory - #34
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The hosted demo has static device pages, but the homepage only exposed them through a JavaScript-driven selector. This adds a static
/devices/directory with one ordinary link per profile, connects it to the homepage, detail pages and sitemap, and gives every detail page a server-rendered profile summary. It also adds a generated GitHub index of all 175 public device URLs, with CI checking that it stays synchronized with the device table.How was this verified?
pnpm format:checkpnpm lint— exits 0; one existing warning remains inpackages/frame/src/react/index.tsx.pnpm check-typespnpm test— 1,197 tests pass.pnpm run check:device-pagespnpm --filter @devicekit/frame demo:build:pages— generates 177 static pages.Checklist
pnpm lintpasses with zero warnings — the existingreact(refs)warning is unrelated to this change.