Skip to content
This repository was archived by the owner on Sep 9, 2026. It is now read-only.

fix(ci): 放行 @electron-internal/extract-zip 的预编译 .node 文件 - #148

Merged
lbb00 merged 1 commit into
mainfrom
fix/electron-internal-extract-zip-guard
Jul 28, 2026
Merged

lbb00 merged 1 commit into
mainfrom
fix/electron-internal-extract-zip-guard

Conversation

@lbb00

@lbb00 lbb00 commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Electron 43.2.0 升级引入的安装期解压依赖 @electron-internal/extract-zip 自带多平台预编译 .node 文件,触发 release.yml 的 native-deps 守卫误报,导致所有 4 个 build-clients 矩阵任务失败(run 30335133447)
  • 在守卫的排除列表中加入对该包的豁免

Test plan

  • 本地对 find node_modules -name '*.node' ... 应用新排除规则,确认不再命中 @electron-internal/extract-zip 下的 .node 文件
  • 合并后确认下一次 Release workflow 的 Guard against accidental native deps 步骤通过

🤖 Generated with Claude Code

Electron 43.2.0 引入的安装期解压工具带多平台预编译二进制,误触发 native-deps 守卫。
@github-actions

Copy link
Copy Markdown

pawl — ✅ no regressions

metric baseline current Δ status
circular-deps 2 2 ±0 ✅ same
code-duplication 325 325 ±0 ✅ same
cognitive-complexity 0 0 ±0 ✅ same
file-length 56 56 ±0 ✅ same
test-coverage 76.87 76.88 +0.01 🎉 better
test-report 4660 4660 ±0 ✅ same
type-coverage 99.78 99.78 ±0 ✅ same
type-escapes 0 0 ±0 ✅ same

🎉 improved: test-coverage — run pawl record to lock in the gains.

@lbb00
lbb00 merged commit 030283d into main Jul 28, 2026
9 checks passed
@lbb00
lbb00 deleted the fix/electron-internal-extract-zip-guard branch July 28, 2026 07:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant