Repository navigation
Block redirect-following and reject malformed auth responses across Node/Java/Go SDKs - #1
Merged
Merged
Conversation
…er characters, and reject malformed auth-token responses across Node/Java/Go SDKs - Default HTTP clients (and any caller-injected client) no longer follow 3xx redirects, closing a path where a redirect could replay the access-token/appSecret to an untrusted host. - Access tokens containing control characters are rejected locally before any request is sent (Node/Go); Java already had this check. - Auth endpoints (client_credentials/code2Session/refreshToken) now reject success responses with a missing/empty accessToken or a malformed expiresAt instead of silently caching or returning a broken value. - CI's generate-check workflow now runs on every push/PR instead of a path-filtered subset that didn't cover the generated directories it's meant to guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default HTTP clients no longer follow 3xx redirects (closing a path that could replay access-token/appSecret to an untrusted host), access tokens with unsafe header characters are rejected locally before any request, and auth endpoints reject malformed success responses (missing/empty accessToken, unparseable expiresAt) instead of silently caching a broken value.
Test plan
npm test(Node): 66/66 passing./gradlew test(Java): 86/86 passinggo test ./...(Go): 48/48 passing