Repository navigation
Guard completed-download book override to local DB books only - #2
Merged
Merged
Conversation
The RemoteBook-context work (147a11e) set IdentificationOverrides.Book from remoteBook.Books when there was exactly one book. CandidateService treats a Book override as authoritative and calls GetDbCandidatesByBook, which requires a valid local DB book ID. If the Book object is stale or unmapped, candidate resolution collapses to zero and import silently fails. Fix: - In CompletedDownloadService and DownloadedBooksCommandService, only set overrides.Book when the candidate has Id > 0 and is confirmed to exist in the local database via IBookService.GetBook(). - In CandidateService, if a Book override produces zero candidates, fall back to author-scoped search instead of dead-ending. This preserves the improved matching when a valid local book is available while preventing import failures from invalid book overrides. https://claude.ai/code/session_01976eMqb4mwazHh13NZkDY5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RemoteBook-context work (147a11e) set IdentificationOverrides.Book from remoteBook.Books when there was exactly one book. CandidateService treats a Book override as authoritative and calls GetDbCandidatesByBook, which requires a valid local DB book ID. If the Book object is stale or unmapped, candidate resolution collapses to zero and import silently fails.
Fix:
This preserves the improved matching when a valid local book is available while preventing import failures from invalid book overrides.
https://claude.ai/code/session_01976eMqb4mwazHh13NZkDY5