Repository navigation
Preserve explicit edition selection during manual import refresh - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ForeignEditionIdeven when the edition is not yet present in the local DBWhy
Manual import could lose the selected edition during refresh if
_editionService.GetEditionByForeignEditionId(...)returned null for a remote-only edition. The subsequent identification pass could then replace the user’s explicit choice with another edition of the same book, sometimes in the wrong language.Changes
ManualImportControllernow falls back to_bookInfo.GetBookInfo(book.ForeignBookId)to resolve the selectedForeignEditionIdManualImportService.UpdateItems()now keeps an explicitly chosen edition pinned when rebuilding the preview rowsNotes
I did not add tests in this pass because the GitHub connector search/index path was not giving me a reliable route to the existing manual-import test fixtures from within this session. The change is intentionally narrow and limited to the manual-import refresh path.