Paul/add edge asset #207

paullinator · 2025-12-19T05:00:12Z

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

Yes
No

Dependencies

none

Description

none

Note

Implements chain-aware asset metadata and expands provider coverage.

Add deposit/payoutChainPluginId, deposit/payoutEvmChainId, and deposit/payoutTokenId to StandardTx; populate across partners (Banxa, ChangeNow, ChangeHero, Exolix, Godex, LetsExchange, LiFi, Moonpay, Sideshift, etc.) using chain mappings and token-id creation
New rango partner integration; update lifi to include chainId/tokenId and improve amount handling
Upgrade providers to newer APIs (e.g., LetsExchange v2, Banxa v2 coins, ChangeNow currencies) and add robust logging via createScopedLog
Add CouchDB indexes for orderId and new chain/token fields; require couchUris in initDbs
Fix payment-type mapping (e.g., Moonpay Revolut/ACH/PIX), improve pagination/logging, and adjust npm scripts (start.*)

^{Written by Cursor Bugbot for commit c81d6fb. This will update automatically on new commits. Configure here.}

To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1212296566914531

Add revolut

Have all plugins just set to undefined for now

Allows backfilling of pluginId/tokenId of all old transactions

Do not error if fiat currency is USD.

cursor · 2025-12-19T05:04:24Z

src/partners/lifi.ts

+          6
+        ) ?? ''} ${payoutAmount}`
+      )
+    }


Bug: Debug console.log left in production code

A console.log statement logs detailed transaction information (orderId, currencies, chain IDs, token IDs, amounts) for every completed Lifi transaction. This appears to be debug/development code that was accidentally left in. It will pollute production logs, potentially leak sensitive transaction data, and cause unnecessary I/O overhead on every completed transaction processed.

cursor · 2025-12-19T05:04:24Z

src/partners/sideshift.ts

+): Promise<EdgeAssetInfo> {
+  if (network == null) {
+    throw new Error(`Missing network for asset: ${asset}`)
+  }


Bug: Missing date cutoff for network field requirement

The getAssetInfo function throws an error if network is null, but unlike other partners (changehero, exolix, godex) there's no date-based cutoff to gracefully handle older transactions. The cleaner at lines 151 and 158 marks depositNetwork and settleNetwork as optional, suggesting historical transactions may not have these fields. Other partners use constants like CHAIN_FIELDS_REQUIRED_DATE to skip asset info backfill for older transactions, but sideshift throws unconditionally, which could cause the entire sync to fail when processing historical data.

src/partners/letsexchange.ts

- Round robin query all rates servers - Increase batch size and query frequency - Do not write unchanged docs

This properly runs 3 plugin queries in parallel. Prior to this change, 3 plugins would get launced and all run to completion before another 3 are launched.

cursor · 2025-12-28T06:38:34Z

src/partners/rango.ts

+  const depositCurrency = firstStep.fromToken.symbol
+  const depositTokenId = firstStep.fromToken.address ?? null
+  const payoutCurrency = lastStep.toToken.symbol
+  const payoutTokenId = lastStep.toToken.address ?? null


TokenId uses raw address without proper formatting

The rango.ts partner uses raw contract addresses directly as tokenId values (firstStep.fromToken.address ?? null), while all other partners consistently use createTokenId() to properly format token addresses. For EVM chains, createTokenId() removes the '0x' prefix and lowercases the address. Without this normalization, the tokenId format will be inconsistent with the rest of the codebase, potentially causing token lookup/matching failures.

Additional Locations (1)

src/partners/rango.ts#L301-L302

Valid point.

src/partners/letsexchange.ts

cursor · 2025-12-28T07:13:41Z

src/partners/moonpay.ts

+      } else if (tx.cardType === undefined) {
+        paymentMethod = 'applepay'
+      }
+      break


Unhandled cardType 'card' causes error for mobile_wallet payments

The getFiatPaymentType function doesn't handle the 'card' value for cardType when paymentMethod is 'mobile_wallet'. The cleaner on line 147 allows cardType to be 'apple_pay', 'google_pay', or 'card', but the switch statement only handles the first two plus undefined. If a transaction has paymentMethod: 'mobile_wallet' with cardType: 'card', paymentMethod remains null and the function throws an error.

This is just an idea to use functions over objects for mappings. More flexible to encode more about the conversion possibilities. It results in simpler calls: ```ts // Determine chainPluginId from networkCode or chainId const chainPluginId = moonpayNetworkToPluginId(networkCode) ?? reverseEvmChainId(chainIdNum) ``` instead of: ``` const chainPluginId = (networkCode != null ? MOONPAY_NETWORK_TO_PLUGIN_ID[networkCode] : undefined) ?? (chainIdNum != null ? REVERSE_EVM_CHAIN_IDS[chainIdNum] : undefined) ``` In general, I think using functions for mapping use-cases results in clearer code. Just an idea.

samholmes

Partial review. I included an idea in my fixup! commit too.

samholmes · 2026-01-07T01:21:35Z

src/partners/moonpay.ts

-  currency: asMoonpayCurrency,
  id: asString,
+  // Common amount field (used by both buy and sell)
+  quoteCurrencyAmount: asOptional(asNumber),


Why does the comment mention that it's used for both buy and sell yet is optional? It wasn't optional before.

I'm not entirely sure merging the types makes sense because we then lose the type strictness. But w/e

samholmes · 2026-01-07T01:28:34Z

src/partners/moonpay.ts

+      } else if (tx.cardType === 'google_pay') {
+        paymentMethod = 'googlepay'
+      } else if (tx.cardType === undefined) {
+        paymentMethod = 'applepay'


Why do we assume applypay by default?

samholmes · 2026-01-07T01:43:09Z

src/partners/moonpay.ts

+  if (chainPluginId != null) {
+    if (
+      contractAddress != null &&
+      contractAddress !== '0x0000000000000000000000000000000000000000'


No provider follows Native Asset Address Convention I hope? (https://eips.ethereum.org/EIPS/eip-7528)

This file was incorrectly being written to the root directory.

cursor · 2026-01-13T00:19:23Z

src/partners/moonpay.ts

+        paymentMethod = 'googlepay'
+      } else if (tx.cardType === undefined) {
+        paymentMethod = 'applepay'
+      }


Unjustified default to Apple Pay when cardType undefined

Medium Severity

When tx.paymentMethod is 'mobile_wallet' and tx.cardType is undefined, the code arbitrarily defaults paymentMethod to 'applepay'. As highlighted by the reviewer's comment "Why do we assume applypay by default?", there's no justification for this assumption. When the data doesn't indicate the payment type, defaulting to Apple Pay could lead to incorrect reporting. Additionally, if cardType is 'card' (a valid type per the cleaner), paymentMethod remains null and the function throws an error.

cursor · 2026-01-13T00:19:23Z

src/partners/moonpay.ts

+
+  // Determine direction based on paymentMethod vs payoutMethod
+  // Buy transactions have paymentMethod, sell transactions have payoutMethod
+  const direction = tx.paymentMethod != null ? 'buy' : 'sell'


Sell transactions with paymentMethod are misclassified as buy

High Severity

The direction determination logic tx.paymentMethod != null ? 'buy' : 'sell' can misclassify transactions. The old asMoonpaySellTx cleaner included paymentMethod: asOptional(asString), meaning sell transactions could have this field. The old code hardcoded direction: 'sell' regardless of paymentMethod presence. Now, if a sell transaction has paymentMethod set, it would be incorrectly classified as buy, causing the code to look for tx.currency (buy-specific) instead of tx.quoteCurrency (sell-specific), likely resulting in a "Missing payout currency" error or incorrect data. This relates to the reviewer's concern about losing type strictness when merging the cleaners.

samholmes

Finally finished with this. Whew

samholmes · 2026-01-13T00:19:45Z

src/partners/changenow.ts

+  pluginParams?: PluginParams
+): Promise<StandardTx> {
+  // Load currency cache before processing transactions
+  await loadCurrencyCache()


Why make this an async function and why not just call this once before the processChangeNowTx calls?

samholmes · 2026-01-13T00:20:57Z

src/partners/changenow.ts

+
+export async function processChangeNowTx(
+  rawTx: unknown,
+  pluginParams?: PluginParams


Can be removed if loadCurrencyCache is moved out of processChangeNowTx

samholmes · 2026-01-13T19:11:33Z

src/partners/sideshift.ts

+  const evmChainId = EVM_CHAIN_IDS[chainPluginId]
+
+  // Get contract address from cache
+  const coinsCache = await fetchSideshiftCoins()


Same suggestion here: call the async function outside of the processSideshiftTx routine and pass in the cache state as a parameter. This prevents turning this method into an async function. I suppose the main motivation for this is to avoid the overhead of promises when the async is only needed. Just makes sense to keep it sync if we can for performance and lesser complexity.

samholmes · 2026-01-13T19:13:31Z

src/partners/banxa.ts

 }

-export function processBanxaTx(rawTx: unknown): StandardTx {
+export async function processBanxaTx(


Same here, can we keep processBanxaTx sync to be consistent with other plugins. This is a internal pattern.

samholmes · 2026-01-13T19:29:22Z

src/queryEngine.ts

+const checkUpdateTx = (
+  oldTx: StandardTx,
+  newTx: StandardTx
+): string[] | undefined => {


Why is undefined needed for the return type?

samholmes · 2026-01-13T21:47:32Z

src/queryEngine.ts

+/** Local datelog for engine-level logs not associated with a specific app/partner */
+const datelog = (...args: unknown[]): void => {
+  const date = new Date().toISOString()
+  console.log(date, ...args)
+}


Can't you just import this from ./util like before?

samholmes · 2026-01-13T21:48:48Z

src/ratesEngine.ts

I'm happy to hear that the rates server bookmarking is fixed. Not sure what was broken about it. It looks like it has something to do with concurrency, but it's not clear.

samholmes · 2026-01-13T21:51:30Z

src/ratesEngine.ts

  currencyB = isFiatCurrency(currencyB) ? `iso:${currencyB}` : currencyB

-  const url = `https://rates2.edge.app/v2/exchangeRate?currency_pair=${currencyA}_${currencyB}&date=${hourDate}`
+  const server = RATES_SERVERS[Math.floor(Math.random() * RATES_SERVERS.length)]


Useful abstraction would be a pickRandomRatesServer function. Optional.

Also this isn't round-robin as the commit message suggests.

samholmes · 2026-01-13T22:03:00Z

src/queryEngine.ts

+        promises.push(promise)
      }
-      datelog(partnerStatus)
+      await Promise.all(promises)


Why are we awaiting all the promises that have already resolved?

I suppose there could be 2 promises unresolved, and we want to wait for those two promises to be resolved before doing 3 more promises for the next app in apps?

This sounds like the thing you're trying to avoid, although limited to one edge case (the end of the plugins array), it seems like it's still possible to be blocked on 3 until they all resolve before doing the next 3.

The only other way I can think of solving this is to remove this await Promise.all(promise) and move the semaphore to outside of the for-loop block for the apps.

samholmes · 2026-01-13T22:04:53Z

src/partners/rango.ts

+  const depositCurrency = firstStep.fromToken.symbol
+  const depositTokenId = firstStep.fromToken.address ?? null
+  const payoutCurrency = lastStep.toToken.symbol
+  const payoutTokenId = lastStep.toToken.address ?? null


Valid point.

samholmes · 2026-01-13T23:09:40Z

src/partners/rango.ts

+  const depositCurrency = firstStep.fromToken.symbol
+  const depositTokenId = firstStep.fromToken.address ?? null
+  const payoutCurrency = lastStep.toToken.symbol
+  const payoutTokenId = lastStep.toToken.address ?? null


Inconsistent tokenId format

The tokenId for Rango assets uses raw contract addresses directly without transformation via createTokenId(). Consider using createTokenId(tokenTypes[chainPluginId], currencyCode, address) for consistency with other partner plugins.

samholmes · 2026-01-13T23:10:44Z

src/partners/banxa.ts

+  contractAddress: string | null
+  pluginId: string | undefined
+}
+let banxaCoinsCache: Map<string, CachedAssetInfo> | null = null


Global cache could become stale

The module-level cache banxaCoinsCache persists for the process lifetime. Since the query engine runs in an infinite loop, this cache never refreshes after the first successful fetch. Consider adding TTL-based invalidation or clearing caches periodically.

This pattern also appears in sideshift, changenow, and letsexchange plugins.

samholmes · 2026-01-13T23:11:05Z

src/partners/letsexchange.ts

+// transactions back to approximately Feb 23, 2022.
+// Transactions before this date may be missing network fields and won't be backfilled.
+// Transactions on or after this date MUST have network fields or will throw.
+const NETWORK_FIELDS_AVAILABLE_DATE = '2022-02-24T00:00:00.000Z'


Unused constant

The constant NETWORK_FIELDS_AVAILABLE_DATE is defined but never used in the code. If this date is important for backwards compatibility (e.g., skipping asset info for older transactions), consider implementing that check. Otherwise, this unused constant should be removed.

samholmes · 2026-01-13T23:11:14Z

src/partners/moonpay.ts

-})
+// Map Moonpay status to Edge status
+// Only 'completed' and 'pending' were found in 3 years of API data
+const statusMap: Record<string, Status> = {


Limited statusMap coverage

The statusMap only handles completed and pending statuses. While the code comment notes these are the only two statuses found in 3 years of API data, Moonpay docs list additional statuses like failed, waitingAuthorization, etc.

Consider either:

Adding mappings for documented Moonpay statuses to prevent future data loss

Logging when an unknown status is encountered (currently defaults silently to other)

samholmes · 2026-01-13T23:11:27Z

src/partners/thorchain.ts

-  }
+    const { swap } = tx.metadata
+    if (swap?.affiliateAddress !== affiliateAddress) {
+      return null


Silent null returns hinder debugging

The makeThorchainProcessTx function silently returns null for several conditions without any logging:

affiliateAddress mismatch

status is not success

no affiliate output found

source/dest asset match (refund)

missing output when pools.length === 2

Consider adding debug-level logging to indicate why transactions are being filtered out, especially for less obvious cases like refund detection.

paullinator added 24 commits July 18, 2025 00:03

Fix hang due to undefined apiKey

e40dcd5

Require couchUris

c0091ec

Fix moonpay

69d3c1f

Add revolut

Use v2 rates api

35424a3

Add index for orderId

196c1b2

Rename yarn scripts to use '.'

486e8be

Properly exit destroyPartition

ac0d516

Add chainId, pluginId, and tokenId fields to StandardTx

f756b6b

Have all plugins just set to undefined for now

Update lifi to provide chainId, pluginId, and tokenId

30376ee

Use ratex v3 if transactions has full pluginId/tokenId values

7a26fb0

Fix banxa by adding ACH payment type

1932ac3

future! paul/v3RatesAndFixes

727de29

Refactor to use common processTx

efc0c87

Include all moonpay txs

035a9ff

Add EdgeAsset info for moonpay

5aea3a8

Add EdgeAsset info for thorchain/maya

405a15c

Add EdgeAsset info for changenow

dc4b881

Add EdgeAsset info for sideshift

5d9c707

Add EdgeAsset info for banxa

e024ee5

Add EdgeAsset info for godex

bd73fde

Add EdgeAsset info for changehero

1f23973

Improve v3 rates logging

34be25d

Check pluginId/tokenId for updating transactions

111da07

Allows backfilling of pluginId/tokenId of all old transactions

Fix ratesEngine bug

1fd2553

Do not error if fiat currency is USD.

cursor bot reviewed Dec 19, 2025

View reviewed changes

paullinator added 4 commits December 20, 2025 19:21

Add EdgeAsset info for letsexchange

bb53298

Add indices for pluginId/tokenId fields

6e9e800

Add EdgeAsset info for exolix

81b8d9c

Add disablePartnerQuery feature

1b5bee6

paullinator force-pushed the paul/addEdgeAsset branch from e7d048f to f8eae85 Compare December 21, 2025 03:21

paullinator added 3 commits December 21, 2025 16:06

Use scoped logging

057fbda

Fix rates server bookmarking

f6b8146

Optimize rates engine

522bf0c

- Round robin query all rates servers - Increase batch size and query frequency - Do not write unchanged docs

paullinator force-pushed the paul/addEdgeAsset branch from f8eae85 to 8466888 Compare December 22, 2025 00:07

For a partner to run with soloPartnerId even if disabled in couch

ddfaa68

paullinator force-pushed the paul/addEdgeAsset branch from 8466888 to ddfaa68 Compare December 24, 2025 22:48

paullinator added 3 commits December 24, 2025 19:13

Use semaphores for queryEngine

2281e89

This properly runs 3 plugin queries in parallel. Prior to this change, 3 plugins would get launced and all run to completion before another 3 are launched.

Add EdgeAsset info for bitrefill

913a852

Add rango query plugin

2f72472

cursor bot reviewed Dec 28, 2025

View reviewed changes

Add max new transactions for letsexchange

764365b

cursor bot reviewed Dec 28, 2025

View reviewed changes

samholmes requested changes Jan 7, 2026

View reviewed changes

Fix issue with testData.json

c81d6fb

This file was incorrectly being written to the root directory.

cursor bot reviewed Jan 13, 2026

View reviewed changes

samholmes requested changes Jan 13, 2026

View reviewed changes

samholmes reviewed Jan 13, 2026

View reviewed changes

Paul/add edge asset #207

Are you sure you want to change the base?

Paul/add edge asset #207

Conversation

paullinator commented Dec 19, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CHANGELOG

Dependencies

Description

Uh oh!

cursor bot Dec 19, 2025

Choose a reason for hiding this comment

Bug: Debug console.log left in production code

Uh oh!

cursor bot Dec 19, 2025

Choose a reason for hiding this comment

Bug: Missing date cutoff for network field requirement

Uh oh!

Uh oh!

cursor bot Dec 28, 2025

Choose a reason for hiding this comment

TokenId uses raw address without proper formatting

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor bot Dec 28, 2025

Choose a reason for hiding this comment

Unhandled cardType 'card' causes error for mobile_wallet payments

Uh oh!

samholmes left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cursor bot Jan 13, 2026

Choose a reason for hiding this comment

Unjustified default to Apple Pay when cardType undefined

Uh oh!

cursor bot Jan 13, 2026

Choose a reason for hiding this comment

Sell transactions with paymentMethod are misclassified as buy

Uh oh!

samholmes left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

paullinator commented Dec 19, 2025 •

edited by cursor bot

Loading