Repository navigation
add c templates appdefinition - #107
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds the ChangesC-Templates Image Integration
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new C templates app definition and exposes it as a selectable landing-page app, while also adjusting image preloading and shared-gateway deployment assets.
Changes:
- Add a new
c-templates-latestAppDefinition (imageghcr.io/eduide/eduide/c-templates). - Expose
c-templates-latestas an additional app (with Bazel/Make build systems) in the combined chart and thetest2environment. - Remove
deployments/shared-gateway/values.yaml.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| deployments/test2.theia-test.artemis.cit.tum.de/values.yaml | Switch the test2 landing page to offer c-templates-latest (Bazel/Make) instead of the previous C entry. |
| deployments/shared-gateway/values.yaml | Removed the shared-gateway values file for non-prod clusters. |
| charts/theia-cloud-combined/values.yaml | Add c-templates preload image and add/hide C apps in landing page configuration (c-latest hidden, c-templates-latest added). |
| charts/theia-appdefinitions/values.yaml | Add the c-templates-latest AppDefinition pointing at the new C templates image. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
KevinGruber2001
force-pushed
the
feat/add-c-templates
branch
from
May 22, 2026 20:29
3c3120d to
d1ffed7
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@charts/theia-cloud-combined/values.yaml`:
- Line 86: The comment documenting the preloading index contract is now
incorrect after inserting "c-templates"
(ghcr.io/eduide/eduide/c-templates:latest); oauth2-proxy has moved from index 12
to index 13, so update the nearby comment that explains
theia-cloud.preloading.images[...] indexing to reflect the new indexes
(including that oauth2-proxy is index 13) and ensure any example or enumeration
in that comment is renumbered consistently after the insertion.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 0c842659-9fd4-44f1-aaaa-18233a33dba1
📒 Files selected for processing (7)
.github/workflows/deploy-theia.ymlcharts/theia-appdefinitions/values.yamlcharts/theia-cloud-combined/values.yamldeployments/shared-gateway/values.yamldeployments/test1.theia-test.artemis.cit.tum.de/values.yamldeployments/test2.theia-test.artemis.cit.tum.de/values.yamldeployments/test3.theia-test.artemis.cit.tum.de/values.yaml
Fangoling
suggested changes
May 26, 2026
Fangoling
left a comment
Fangoling
left a comment
Member
There was a problem hiding this comment.
Looks good and works on the test server. I have some minor comments regarding the 'documentation' comments.
Do we need to add the new template images to the staging and prod envs as well?
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
deployments/theia-staging.artemis.cit.tum.de/values.yaml (1)
76-77:⚠️ Potential issue | 🔴 CriticalPreload index comment is incorrect for staging.
The comment states "Index 13 is oauth2-proxy", but oauth2-proxy is currently at index 12 in staging because
c-templatesis missing from the preloading list. Oncec-templates:latestis added (as it is in test1), oauth2-proxy will shift to index 13 and the comment will become correct.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@deployments/theia-staging.artemis.cit.tum.de/values.yaml` around lines 76 - 77, The staging values.yaml comment about preload indices is wrong because oauth2-proxy is currently at index 12 (not 13) due to the missing c-templates image; either add "c-templates:latest" to the preloading list so oauth2-proxy moves to index 13 (matching the comment) or update the comment to state that oauth2-proxy is at index 12; locate the preload list and the entries for "c-templates" and "oauth2-proxy" and make the change so indices and comment remain consistent.
🧹 Nitpick comments (1)
deployments/theia-staging.artemis.cit.tum.de/values.yaml (1)
60-60: Consider the implications of using:latesttags in staging.Switching from pinned tags (
2026-05-05) to:latestmeans staging will automatically pull the most recent images. While this enables continuous testing of new builds, it can introduce:
- Non-reproducible deployments if images change between rollouts
- Unexpected breaking changes from upstream image updates
- Difficulty troubleshooting issues tied to specific image versions
For a staging environment, this trade-off may be acceptable if the goal is to detect integration issues early. If stability is needed for regression testing or demos, consider using short-lived pinned tags (e.g., weekly releases) instead.
Also applies to: 69-69, 80-91, 103-103, 171-171
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@deployments/theia-staging.artemis.cit.tum.de/values.yaml` at line 60, The deployment is using an unpinned image tag ("image: ghcr.io/eduide/eduide-cloud/operator:latest") which causes non-reproducible and potentially unstable staging rollouts; change the operator image references to a pinned tag or configurable value (e.g., set a specific release tag like 2026-05-05 or wire the tag to a chart value such as image.tag) for all occurrences (the "image: ghcr.io/eduide/eduide-cloud/operator:latest" lines and the other referenced image entries) so staging pulls a deterministic image, or implement a short-lived automated tag strategy (weekly release tag) if you want frequent updates while retaining reproducibility.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@deployments/theia-staging.artemis.cit.tum.de/values.yaml`:
- Around line 78-93: The staging values.yaml preloading list is missing the
c-templates image causing app launch failures and index mismatches; add the
ghcr.io/eduide/eduide/c-templates:latest entry into the preloading.images array
(near the other eduide language/template images in the preloading block) so the
c-templates image is pre-pulled and the image index ordering used by the landing
page apps and workflow --set overrides remains correct.
---
Duplicate comments:
In `@deployments/theia-staging.artemis.cit.tum.de/values.yaml`:
- Around line 76-77: The staging values.yaml comment about preload indices is
wrong because oauth2-proxy is currently at index 12 (not 13) due to the missing
c-templates image; either add "c-templates:latest" to the preloading list so
oauth2-proxy moves to index 13 (matching the comment) or update the comment to
state that oauth2-proxy is at index 12; locate the preload list and the entries
for "c-templates" and "oauth2-proxy" and make the change so indices and comment
remain consistent.
---
Nitpick comments:
In `@deployments/theia-staging.artemis.cit.tum.de/values.yaml`:
- Line 60: The deployment is using an unpinned image tag ("image:
ghcr.io/eduide/eduide-cloud/operator:latest") which causes non-reproducible and
potentially unstable staging rollouts; change the operator image references to a
pinned tag or configurable value (e.g., set a specific release tag like
2026-05-05 or wire the tag to a chart value such as image.tag) for all
occurrences (the "image: ghcr.io/eduide/eduide-cloud/operator:latest" lines and
the other referenced image entries) so staging pulls a deterministic image, or
implement a short-lived automated tag strategy (weekly release tag) if you want
frequent updates while retaining reproducibility.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 3ecf51a7-a5ce-4765-b9ca-c3360650301e
📒 Files selected for processing (4)
deployments/test1.theia-test.artemis.cit.tum.de/values.yamldeployments/test2.theia-test.artemis.cit.tum.de/values.yamldeployments/test3.theia-test.artemis.cit.tum.de/values.yamldeployments/theia-staging.artemis.cit.tum.de/values.yaml
🚧 Files skipped from review as they are similar to previous changes (2)
- deployments/test3.theia-test.artemis.cit.tum.de/values.yaml
- deployments/test2.theia-test.artemis.cit.tum.de/values.yaml
Fangoling
approved these changes
Jun 5, 2026
Fangoling
left a comment
Fangoling
left a comment
Member
There was a problem hiding this comment.
LGTM, the new change to staging to use latest tags make sense.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Chores