Conversation
Moving production to EduIDE 1.3.0 took reading the README, AGENTS.md, renovate.json and the chart's values to work out that this repository chooses a chart version and the chart chooses image tags - and that trying to move the IDE version from here alone leads to versions.ide, which is an override for unreleased images rather than a release path. Writes that down, with the preconditions worth checking before a production PR exists: the chart version is published, the images it pins are published, and the render prints the tags you expect. Also the thing that nearly shipped: a temporary versions.ide pin whose comment named the condition for removing it, which a release moved past. Nothing would have failed - Mannheim would simply have stayed on a pull request's images while everything else moved. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 15 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Add the referenced skill file or remove the documentation entry.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Documents the intended location for the version-movement skill.
Changes:
- Adds
.claude/skills/toAGENTS.md. - References a skill file that is not included in the submitted changes.
| File | Summary |
|---|---|
AGENTS.md |
Documents the skills directory; the referenced skill file is missing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The skill in the previous commit never reached the repository: .gitignore excludes .claude, so `git add -A` skipped it silently and the commit carried only the AGENTS.md line pointing at a path with nothing behind it. Caught in review by Copilot. Local Claude state should stay out, but skills are shared and belong in the repository - EduIDE-Helm already tracks its own. Ignoring .claude/* rather than .claude lets the negation work: git does not descend into an excluded directory, so the directory itself has to stay includable. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The skill contains inaccurate or incomplete Renovate and image-validation guidance that should be corrected.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
Resolved since last review (1)
| **Production and staging go in separate pull requests.** Not a style | ||
| preference: bundling them means production cannot be reverted without also | ||
| reverting the environment that proved it. `renovate.json` enforces the same | ||
| split for automated bumps, and production bumps never arrive unasked - somebody | ||
| ticks the box on the Dependency Dashboard, because bumping `chartVersion` in a | ||
| production environment *is* the release procedure. |
| ```bash | ||
| gh run list --repo EduIDE/EduIDE --event release --limit 1 | ||
| docker manifest inspect ghcr.io/eduide/eduide/java-17:1.3.0 |
Adds
.claude/skills/move-a-version.md, from moving production to EduIDE 1.3.0 today.What it took to work out
That this repository chooses a chart version and the chart chooses image tags. It is stated in three places - the README's "Move production" row, AGENTS.md's version-knob paragraph,
docs/environments.md's table - but none of them says the thing plainly enough that you avoid the wrong turn: trying to move the IDE version from here alone, which leads toversions.ide, which is an override for unreleased images rather than a release path.The skill leads with the three-repository chain, then the preconditions that are worth checking before a production PR exists at all:
helm show chart --version)helm template ... | grep -oEand the single most useful check in the listThe thing that nearly shipped
Mannheim carried
versions.ide: pr-170with a comment naming exactly when to remove it - "once #170 merges and a release publishes a numbered tag". Both became true. Nothing would have failed: Mannheim would have quietly stayed on a pull request's images while every other environment moved, with a chart bump beside the pin making it look like something had happened. The skill says to check those comments whenever a release moves past them.Also covered
Why production and staging are separate PRs (revertability, and
renovate.jsonenforcing the same split), whatvalidate.ymldoes and does not prove, Rollback rather than a revert commit, and thateduide-clusteris a workflow input nothing here bumps.Companion PRs: EduIDE-Helm#45 (chart release process and skill), EduIDE#192 (image build failures).
🤖 Generated with Claude Code