Enhance Fides v2 features and documentation updates#105
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1199fa313c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const runtimeAttestationValid = typeof body.runtimeAttestationValid === 'boolean' | ||
| ? body.runtimeAttestationValid | ||
| : await verifyLocalRuntimeAttestation(typeof body.attestationId === 'string' ? body.attestationId : undefined, targetAgentId) |
There was a problem hiding this comment.
For POST /sessions, a caller requesting a high-risk capability can include runtimeAttestationValid: true, and this value is passed directly into evaluateFidesPolicy instead of verifying a stored attestation. That bypasses the intended runtime-attestation/approval gate and lets unauthenticated request payload state turn a session from APPROVAL_REQUIRED into an authorized grant; the same pattern on approvalGranted should also be tied to an actual approved request rather than a client boolean.
Useful? React with 👍 / 👎.
| id: `${card.identity.did}#ed25519`, | ||
| type: 'Ed25519' as const, | ||
| publicKey: bs58.encode(card.identity.publicKey), |
There was a problem hiding this comment.
When agentd runs with the new default SQLite local-state store, identities are saved via JSON and reloaded in hydrateLocalState without converting identity.publicKey back to a Uint8Array; creating another AgentCard for that persisted identity after a restart then reaches this bs58.encode(card.identity.publicKey) call with a plain JSON object and fails instead of creating the card. Normalizing/reviving the key from publicKeyHex or accepting serialized byte arrays here would keep persisted local identities usable across restarts.
Useful? React with 👍 / 👎.
2 participants
No description provided.