Merged
Conversation
lwJi
added a commit
to lwJi/SpacetimeX
that referenced
this pull request
Jul 6, 2025
* NewRadX: Prevent NewRadX from being applied at symmetry boundaries * AHFinderDirect: update parfile for unit test * scripts: turn off AHFinderDirect because it's too expensive * CI: update unit tests * NewRadX: remove superfluous inheritance from CarpetX * TestNewRadX: rename CarpetX to CarpetXRegrid * scripts: rename option -DSIMD_CPU to -DSIMD_DISABLE * Z4c: Update to nvtx3 * TestNewRadX: Use symmetries and shorten test case * Z4c: Switch to nvtx3 (because AMReX uses it) * NewRadX: Use driver.hxx from CarpetX via USES INCLUDE syntax * Z4c: fix typo in calculating HC and MtC * Z4c: add more comments for typo when calculate HC and MtC * scripts: update config file (EinsteinToolkit#55) * Z4c: update unit test (EinsteinToolkit#58) * Z4c: update unit test * Multipole: update unit test --------- Co-authored-by: Cheng-Hsin Cheng <chcheng3@illinois.edu> Co-authored-by: Roland Haas <rhaas@illinois.edu> Co-authored-by: Cheng-Hsin Cheng <82361123+chcheng3@users.noreply.github.com> Co-authored-by: Erik Schnetter <schnetter@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’ve checked the Git history, and there have been no changes to Z4c since the last successful CI test. Additionally, I’m aware that others are using the main branch version of Z4c without any issues.