fix(sandbox): overlay patched Tornado and Python packages onto the image - #30
Merged
Merged
Conversation
Fedora 44 ships python3-tornado 6.5.7 (GHSA-mpf4-983q-p7j4), pulled in by python3-ipykernel, plus pypdf 4.x, soupsieve, pygments and pip builds that lag their upstream security releases. Grype flags every one of them as an open, fixable CVE in this bundle's sandbox image. Port fleet's config/default/sandbox/Containerfile fix: pip-install the current PyPI releases (tornado>=6.5.8) into /usr/local, `rpm -e --nodeps` the vulnerable RPM copies, and fail the build if any RPM copy still shadows the overlay. Also run `microdnf upgrade` before `install` so a rebuild refreshes base-layer packages inherited from fedora-minimal:latest. Hand-ported, not synced: bundles are peers of fleet's default bundle. The publish workflow rebuilds and pushes the image on merge; running boxes pick it up on their next `fleet update` / image rebuild. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed, and why
Fedora 44 ships
python3-tornado6.5.7, affected by GHSA-mpf4-983q-p7j4, andpython3-ipykernel(which this image installs) requires it. The same base also carries pypdf 4.x, soupsieve, pygments and pip builds that lag their upstream security releases, so a Grype scan of this bundle's sandbox image reports every one of them as an open, fixable CVE.This ports the fix fleet made to its own
config/default/sandbox/Containerfile: pip-install the current PyPI releases (tornado>=6.5.8, pypdf, soupsieve, pygments, pip) into/usr/local,rpm -e --nodepsthe vulnerable RPM copies, and fail the build if any RPM copy still shadows the overlay. It also runsmicrodnf upgradebeforeinstallso a rebuild refreshes base-layer packages inherited fromfedora-minimal:latest.Hand-ported, not synced — bundles are peers of fleet's default bundle.
How you verified it
microdnf repoqueryonfedora-minimal:latestthat the repo'spython3-tornadois 6.5.7 and thatpython3-ipykernelrequires it.sandbox/Containerfilewith rootless Podman: the overlay step installstornado-6.5.8,pypdf-6.17.0,soupsieve-2.9.2,pygments-2.21.0,pip-26.2.1, and the shadow check passes.tornado,pypdf,pygments,soupsieve,pip,ipykernel,jupyter_client,IPython,bs4,pandas,matplotliball import;tornado.versionis 6.5.8 from/usr/local;rpm -q python3-tornado python3-pypdfreports neither installed..grype.yaml,--only-fixed --fail-on high: No vulnerabilities found.RUNblock is byte-identical across the five ElcanoTek bundles, so one build certifies the same layers in each.Scope and deviations
Only
sandbox/Containerfilechanges. Merging triggers the existingPublish sandbox imageworkflow (push tomain,sandbox/**), so the fixed image is published automatically; running boxes pick it up on their nextfleet update/ image rebuild. No manifest, MCP, persona or protocol change.