docs: the branding block also brands the Auth service - #32
Merged
Merged
Conversation
The Auth service now reads the same `branding:` block Fleet does when its `AUTH_CLIENT_CONFIG_DIR` points at a checkout of this bundle. The README's Branding section says so, lists the fields Auth consumes, and points at the config check to run after a branding change, so a bundle forked from this template reproduces both services' branding from one manifest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
The Auth service (ElcanoTek/auth, password mode) reads the same
branding:block Fleet does whenAUTH_CLIENT_CONFIG_DIRpoints at a bundle. The README now says so, so a client bundle forked from this template reproduces the branding of both services from one manifest.Fix
app_name,login_title,login_tagline,logo,colors), that nothing extra is needed in the bundle, that Auth refuses to start on an unreadable bundle, and the-check-configstep. Links to auth's DEPLOY.md.Tests
Docs only; no code changed.