Skip to content

Upload the weekly Grype scan under the PR gate's SARIF category #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bradflaugher merged 1 commit into from
Sep 14, 2026
Merged

Upload the weekly Grype scan under the PR gate's SARIF category #1502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/grype-scheduled.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,12 @@ jobs:
if: ${{ !cancelled() && hashFiles('grype-results.sarif') != '' }}
with:
sarif_file: 'grype-results.sarif'
category: 'grype-scheduled'
# Share the PR gate's category: a distinct category published only on
# main makes GitHub Advanced Security expect that configuration on
# every PR and report "1 configuration not found", because this weekly
# workflow never runs on PRs. (The legacy 'grype-scheduled' analyses
# on main were deleted via the code-scanning API; see docs/TESTING.md.)
category: 'grype-sandbox-image'


alarm:
Expand Down
17 changes: 14 additions & 3 deletions docs/TESTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,9 +615,20 @@ run it in CI or with the commands above.
A **non-blocking** weekly scan (Mondays 09:00 UTC; also `workflow_dispatch`)
rebuilds the image against the latest unpinned `fedora-minimal:latest` base and
reports **all** findings — including unfixed ones, with no `--fail-on` /
`--only-fixed` — to the Security tab (category `grype-scheduled`), so a
newly-disclosed CVE against the existing image surfaces as an informational alert
rather than blocking `main`. It is never a PR gate.
`--only-fixed` — so a newly-disclosed CVE against the existing image surfaces as
an informational alert rather than blocking `main`. It is never a PR gate.
Findings upload under the same `grype-sandbox-image` category as the per-PR gate:
a category GitHub has seen on `main` is expected on every PR, and a category
published only by this cron lane made Advanced Security report a missing
configuration on each one. GitHub keeps one result set per `(tool, category,
commit)`, so the weekly upload for the tip of `main` replaces the push-run's
results for that commit, and a rebuilt image or refreshed advisory data can
therefore change alert state on `main` without a source change; weekly results
are no longer retained as a separate configuration. (One-time cleanup: renaming
the category does not retire the configuration GitHub already recorded, so the
existing `grype-scheduled` analyses on `main` must be deleted once through the
code-scanning API — newest first, the last with `confirm_delete=true` — before
the missing-configuration check disappears from PRs.)

---

Expand Down