Calculate weekly campaign KPI changes from comparable weeks - #90
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Weekly channel KPI deltas were always an em dash. They now compare each complete Monday–Sunday bucket with the preceding calendar week in the loaded, filtered history, using the same KPI definition as cards and tables.
Direction follows each channel's
lowerIsBettersetting. Partial weeks, missing observations, unavailable or zero baselines, and the Total row remain unavailable. An observed zero-denominator day does not suppress an otherwise valid weekly ratio. Weekly CSV uses the same calculation records, including KPI values and fractional changes, so it reconciles to the table.Closes #55.
Validation
Existing pages receive the corrected comparisons after template sync and an explicitly reviewed rerender onto the new immutable revision.
Checklist
npm testpassesnpm run test:browserandbash test/run-integration.shpass, or the PR says why they were not runallow-same-originnever joinsallow-scriptsScreenshots
Browser regressions verify the weekly values, delta text, direction colors and corresponding CSV cells.