Align navigation preflight with raw pages and deck exceptions - #93
Merged
Merged
Conversation
obsessixnv
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raw pages that read
#pages-navwere incorrectly told to redeploy as themed, even though portal-authorised raw renders already receive the navigation payload. Preflight now follows the renderer's reader/deck detection: ordinary raw and themed pages receive no navigation warning, while a Bento deck that reads the deliberately absent block gets advice to keep its mode and remove or guard the reader.The API and authoring docs explain the portal, no-portal and deck cases without recommending a rendering change. Static preflight does not assume which portal will authorise a later request.
Closes #33.
Validation: 271 unit tests, 37 focused page-switcher/Bento browser tests, the full integration suite, dependency audit at the required high-severity threshold, and shell syntax checks passed. Regression tests reproduce the prior false warnings and compare the advice with real render output; MCP checks cover deploy-time and stored-version preflight responses.