Reject invalid campaign dashboard dates before applying filters - #94
Merged
Merged
Conversation
obsessixnv
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56.
Typing
02/31/2026previously applied March 3, and typed dates could bypass the reporting bounds enforced by the calendar. The campaign dashboard now validates completeMM/DD/YYYYdates, calendar components, endpoint order, and the same inclusive reporting span before applying a filter. Invalid text stays visible with an accessible inline error, survives calendar navigation and edits to the other endpoint, and leaves the applied filter unchanged. Calendar selection and presets can replace an invalid edit; a single calendar day remains a valid range.The shipped template gets a new immutable revision on sync. Existing pages retain their pinned version until a reviewed
rerender_page_from_templateupdate.Validation: 269 unit tests, all 298 browser tests (including five new date regressions), the full integration suite, dependency audit at the required high-severity threshold, and shell syntax checks passed. All CI checks passed on Node 20.19.0, 22.12.0, and 24, including CodeQL. The original invalid-date regression failed against the unchanged template before the fix. Coverage includes leap-year/century rules, impossible and partially numeric dates, trailing text, inclusive reporting bounds, empty and reversed ranges, cancel/reopen, and single-day selection.