fix(remote-workspace): replace crashing Material icon lib with react-file-icon#181
Merged
Merged
Conversation
…file-icon react-material-icon-theme@1.2.0 bundles a React-19 JSX runtime that reads `recentlyCreatedOwnerStacks` off React's internals — undefined under this project's React 18 — so the Remote Workspace tree threw the moment it rendered (repros in a plain renderToString). Its icon chunk loaded fine (the 304 was a red herring); the crash was at render. Swap it for react-file-icon, which the app already uses for chat attachments (Seti palette, colored per-extension, React-18-safe). Folders keep the lucide glyph. Bonus: drops the ~279 kB-gzip monolith and its lazy chunk entirely — react-file-icon is tiny, so no lazy boundary is needed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
haowei2000
added a commit
that referenced
this pull request
Jul 13, 2026
Promote develop → main: fix Remote Workspace icon crash (#181)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix for a crash now live on main (#180). Clicking Remote Workspace threw immediately.
Root cause
react-material-icon-theme@1.2.0bundles a React-19 JSX runtime that readsrecentlyCreatedOwnerStacksoff React's shared internals — which isundefinedunder this project's React 18 — so the file tree threw the instant it rendered. Reproduced in a plainrenderToString:The 304 on the icon chunk was a red herring — it loaded fine; the crash was at render. It's a library packaging bug (it should externalize
react/jsx-runtime), not fixable on our side.Fix
Swap to
react-file-icon— already a project dependency (used for chat attachments), Seti palette, colored per-extension, React-18-safe (verified viarenderToStringacross ts/rs/py/json/md/dockerignore). Folders keep the lucide glyph.Bonus: removes the ~279 kB-gzip monolith and its lazy chunk entirely; react-file-icon is tiny, so no lazy boundary is needed.
RemoteWorkspaceDialogchunk stays ~8.9 kB gzip.Verification
MaterialFsIconchunk is gone from the output.🤖 Generated with Claude Code